Use variable to improve readability #5

New Issue

GuilloteauQ · 2024-07-11T18:28:05+02:00

GuilloteauQ commented

2024-07-11 18:28:05 +02:00

		ecg.py
		Lines 145 to 146 in 2f779d0ab0
	
				        pkglist_process = subprocess.run(["docker", "run", "--rm", config["image_name"]] + pkgmgr_cmd[pkgmgr][0].split(" "), cwd=path, capture_output=True)

				        format_process = subprocess.run("cat << EOF | " + pkgmgr_cmd[pkgmgr][1] + "\n" + pkglist_process.stdout.decode("utf-8") + "EOF", cwd=path, capture_output=True, shell=True)

Create a variable to store pkgmgr_cmd[pkgmgr][1] and pkgmgr_cmd[pkgmgr][0] to improve readability

https://forge.chapril.org/GuilloteauQ/study-docker-repro-longevity/src/commit/2f779d0ab09ef81681999c91cfd9f3f27ab621ea/ecg.py#L145-L146 Create a variable to store `pkgmgr_cmd[pkgmgr][1]` and `pkgmgr_cmd[pkgmgr][0]` to improve readability

antux18 referenced this issue from a commit

2024-07-16 10:21:34 +02:00

Now using f-strings, closing #6. Made path-related cmd args required, closing #7. Used variables in check_env for readability, closing #5.

antux18 closed this issue

2024-07-16 10:21:50 +02:00

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: GuilloteauQ/study-docker-repro-longevity#5

	pkglist_process = subprocess.run(["docker", "run", "--rm", config["image_name"]] + pkgmgr_cmd[pkgmgr][0].split(" "), cwd=path, capture_output=True)
	format_process = subprocess.run("cat << EOF \| " + pkgmgr_cmd[pkgmgr][1] + "\n" + pkglist_process.stdout.decode("utf-8") + "EOF", cwd=path, capture_output=True, shell=True)