From c757fb4357e974eae3ef0d649747d947ed4e7db7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Gomez?= Date: Wed, 16 Mar 2022 20:24:24 +0100 Subject: [PATCH] Set default backlog_lines = 0 (fixes Debian bug #818374) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This would have defaults move to backlog_always=false / log=true / backlog_lines=0, which should not cause much trouble as backlog will be reset after being displayed. Also, it is doubtfuk anyone would be keeping the default of 10 for backlog as it is pretty much an undesirable configuration. We need to annouce this change as important though, so users having log = false are aware memory usage could increase if they don't set it manually to another value. Signed-off-by: Loïc Gomez --- bip.conf.5 | 2 +- scripts/bipgenconfig | 2 +- src/defaults.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bip.conf.5 b/bip.conf.5 index 147bd95..1f44856 100644 --- a/bip.conf.5 +++ b/bip.conf.5 @@ -227,7 +227,7 @@ This option should of course not be enabled if \fBbacklog_lines\fP is 0 ! If you still want to do so, don't forget to \fB/BIP BLRESET\fP sometimes. .TP -\fBbacklog_lines\fP (default: \fB10\fP) +\fBbacklog_lines\fP (default: \fB0\fP) If set to 0, BIP will replay all the logs since last client disconnect. Else, it'll replay exactly \fBbacklog_lines\fP lines on each channel and privates. Be aware that BIP will replay \fBbacklog_lines\fP lines of all privates, even diff --git a/scripts/bipgenconfig b/scripts/bipgenconfig index ddaef70..4fb6d23 100755 --- a/scripts/bipgenconfig +++ b/scripts/bipgenconfig @@ -119,7 +119,7 @@ my %optdesc = ( 'optional' => 1, 'depends' => 'log', 'depval' => 'true', 'desc' => 'Do you want to activate backlog {play back logs} system ?' }, - 'backlog_lines' => { 'type' => 'i', 'adv' => 0, 'default' => '10', + 'backlog_lines' => { 'type' => 'i', 'adv' => 0, 'default' => '0', 'optional' => 1, 'depends' => 'backlog', 'depval' => 'true', 'desc' => 'How much line do you want bip to play back upon client connect' . diff --git a/src/defaults.h b/src/defaults.h index eaf915d..ce24078 100644 --- a/src/defaults.h +++ b/src/defaults.h @@ -19,7 +19,7 @@ #define DEFAULT_BACKLOG 1 #define DEFAULT_ALWAYS_BACKLOG 0 #define DEFAULT_BL_MSG_ONLY 0 -#define DEFAULT_BACKLOG_LINES 10 +#define DEFAULT_BACKLOG_LINES 0 #define DEFAULT_BACKLOG_TIMESTAMP BLTSTime #define DEFAULT_BLRESET_ON_TALK 0 #define DEFAULT_BLRESET_CONNECTION 0