Handling null Uri when selecting file & Prevent double large file transfer

This commit is contained in:
Matéo Duparc 2021-05-05 18:07:38 +02:00
parent 58804bef67
commit e7e3db60b4
Signed by: hardcoresushi
GPG Key ID: 007F84120107191E
4 changed files with 27 additions and 17 deletions

View File

@ -28,9 +28,7 @@
</intent-filter> </intent-filter>
</receiver> </receiver>
<activity <activity android:name=".ChatActivity"/>
android:name=".ChatActivity"
android:windowSoftInputMode="adjustResize"/>
<activity android:name=".MainActivity"> <activity android:name=".MainActivity">
<intent-filter android:label="@string/share_label"> <intent-filter android:label="@string/share_label">
<action android:name="android.intent.action.SEND"/> <action android:name="android.intent.action.SEND"/>

View File

@ -23,6 +23,7 @@ import sushi.hardcore.aira.databinding.DialogFingerprintsBinding
import sushi.hardcore.aira.databinding.DialogInfoBinding import sushi.hardcore.aira.databinding.DialogInfoBinding
import sushi.hardcore.aira.utils.FileUtils import sushi.hardcore.aira.utils.FileUtils
import sushi.hardcore.aira.utils.StringUtils import sushi.hardcore.aira.utils.StringUtils
import java.io.FileNotFoundException
import java.util.* import java.util.*
class ChatActivity : AppCompatActivity() { class ChatActivity : AppCompatActivity() {
@ -39,15 +40,19 @@ class ChatActivity : AppCompatActivity() {
if (::airaService.isInitialized && uri != null) { if (::airaService.isInitialized && uri != null) {
contentResolver.query(uri, null, null, null, null)?.let { cursor -> contentResolver.query(uri, null, null, null, null)?.let { cursor ->
if (cursor.moveToFirst()) { if (cursor.moveToFirst()) {
contentResolver.openInputStream(uri)?.let { inputStream -> try {
val fileName = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME)) contentResolver.openInputStream(uri)?.let { inputStream ->
val fileSize = cursor.getLong(cursor.getColumnIndex(OpenableColumns.SIZE)) val fileName = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME))
airaService.sendFileTo(sessionId, fileName, fileSize, inputStream)?.let { msg -> val fileSize = cursor.getLong(cursor.getColumnIndex(OpenableColumns.SIZE))
chatAdapter.newMessage(ChatItem(true, msg)) airaService.sendFileTo(sessionId, fileName, fileSize, inputStream)?.let { msg ->
} chatAdapter.newMessage(ChatItem(true, msg))
if (airaService.contacts.contains(sessionId)) { }
lastLoadedMessageOffset += 1 if (airaService.contacts.contains(sessionId)) {
lastLoadedMessageOffset += 1
}
} }
} catch (e: FileNotFoundException) {
Toast.makeText(this, e.localizedMessage, Toast.LENGTH_SHORT).show()
} }
} }
cursor.close() cursor.close()
@ -70,7 +75,9 @@ class ChatActivity : AppCompatActivity() {
chatAdapter = ChatAdapter(this@ChatActivity, ::onClickSaveFile) chatAdapter = ChatAdapter(this@ChatActivity, ::onClickSaveFile)
binding.recyclerChat.apply { binding.recyclerChat.apply {
adapter = chatAdapter adapter = chatAdapter
layoutManager = LinearLayoutManager(this@ChatActivity, LinearLayoutManager.VERTICAL, false) layoutManager = LinearLayoutManager(this@ChatActivity, LinearLayoutManager.VERTICAL, false).apply {
stackFromEnd = true
}
addOnScrollListener(object : RecyclerView.OnScrollListener() { addOnScrollListener(object : RecyclerView.OnScrollListener() {
fun loadMsgsIfNeeded(recyclerView: RecyclerView) { fun loadMsgsIfNeeded(recyclerView: RecyclerView) {
if (!recyclerView.canScrollVertically(-1) && ::airaService.isInitialized) { if (!recyclerView.canScrollVertically(-1) && ::airaService.isInitialized) {

View File

@ -8,6 +8,7 @@ import android.net.nsd.NsdServiceInfo
import android.os.* import android.os.*
import android.os.Process.THREAD_PRIORITY_BACKGROUND import android.os.Process.THREAD_PRIORITY_BACKGROUND
import android.util.Log import android.util.Log
import android.widget.Toast
import androidx.annotation.RequiresApi import androidx.annotation.RequiresApi
import androidx.core.app.NotificationCompat import androidx.core.app.NotificationCompat
import androidx.core.app.NotificationManagerCompat import androidx.core.app.NotificationManagerCompat
@ -16,7 +17,6 @@ import sushi.hardcore.aira.*
import java.io.IOException import java.io.IOException
import java.io.InputStream import java.io.InputStream
import java.net.* import java.net.*
import java.nio.ByteBuffer
import java.nio.channels.* import java.nio.channels.*
class AIRAService : Service() { class AIRAService : Service() {
@ -143,10 +143,14 @@ class AIRAService : Service() {
return msg return msg
} }
} else { } else {
val fileTransfer = SendFileTransfer(fileName, fileSize, inputStream) if (sendFileTransfers[sessionId] == null && receiveFileTransfers[sessionId] == null) {
sendFileTransfers[sessionId] = fileTransfer val fileTransfer = SendFileTransfer(fileName, fileSize, inputStream)
createFileTransferNotification(sessionId, fileTransfer) sendFileTransfers[sessionId] = fileTransfer
sendTo(sessionId, Protocol.askLargeFile(fileSize, fileName)) createFileTransferNotification(sessionId, fileTransfer)
sendTo(sessionId, Protocol.askLargeFile(fileSize, fileName))
} else {
Toast.makeText(this, R.string.file_transfer_already_in_progress, Toast.LENGTH_SHORT).show()
}
} }
return null return null
} }

View File

@ -71,4 +71,5 @@
<string name="remove_contact">Remove contact</string> <string name="remove_contact">Remove contact</string>
<string name="details">Details</string> <string name="details">Details</string>
<string name="your_addresses">Your IP addresses:</string> <string name="your_addresses">Your IP addresses:</string>
<string name="file_transfer_already_in_progress">Another file transfer is already in progress</string>
</resources> </resources>