hardcoresushi/libcryfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Add test cases for writing into leaves

Browse Source
This commit is contained in:
Sebastian Messmer 2015-03-04 21:56:48 +01:00
parent 3a01f95467
commit 31417f8e05
1 changed files with 21 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
test/implementations/onblocks/datanodestore/DataLeafNodeTest.cpp
View File

@ -18,6 +18,8 @@ using std::unique_ptr;
using std::make_unique; using std::make_unique;
using std::string; using std::string;
//TODO Split into multiple files
using cpputils::dynamic_pointer_move; using cpputils::dynamic_pointer_move;
using blockstore::BlockStore; using blockstore::BlockStore;
@ -34,6 +36,7 @@ class DataLeafNodeTest: public Test {
public: public:
static constexpr uint32_t BLOCKSIZE_BYTES = 1024; static constexpr uint32_t BLOCKSIZE_BYTES = 1024;
static constexpr DataNodeLayout LAYOUT = DataNodeLayout(BLOCKSIZE_BYTES);
DataLeafNodeTest(): DataLeafNodeTest():
_blockStore(make_unique<FakeBlockStore>()), _blockStore(make_unique<FakeBlockStore>()),
@ -111,6 +114,7 @@ public:
}; };
constexpr uint32_t DataLeafNodeTest::BLOCKSIZE_BYTES; constexpr uint32_t DataLeafNodeTest::BLOCKSIZE_BYTES;
constexpr DataNodeLayout DataLeafNodeTest::LAYOUT;
TEST_F(DataLeafNodeTest, CorrectKeyReturnedAfterInitialization) { TEST_F(DataLeafNodeTest, CorrectKeyReturnedAfterInitialization) {
auto block = blockStore->create(BLOCKSIZE_BYTES); auto block = blockStore->create(BLOCKSIZE_BYTES);
@ -264,11 +268,6 @@ TEST_F(DataLeafNodeTest, CopyDataLeaf) {
EXPECT_NE(data, *(char*)loadData(*copied).data()); EXPECT_NE(data, *(char*)loadData(*copied).data());
} }
/* TODO
* The following test cases test reading/writing part of a leaf. This doesn't make much sense,
* since the new leaf abstraction doesn't offer read()/write() anymore, but direct data pointer access.
* However, these test cases might make sense wherever the read()/write() for a leaf will be implemented.
* In case they're not needed then, delete them.
struct DataRange { struct DataRange {
DataRange(size_t leafsize_, off_t offset_, size_t count_): leafsize(leafsize_), offset(offset_), count(count_) {} DataRange(size_t leafsize_, off_t offset_, size_t count_): leafsize(leafsize_), offset(offset_), count(count_) {}
@ -298,17 +297,17 @@ public:
auto newleaf = nodeStore->createNewLeafNode(); auto newleaf = nodeStore->createNewLeafNode();
newleaf->resize(GetParam().leafsize); newleaf->resize(GetParam().leafsize);
newleaf->write(GetParam().offset, GetParam().count, to_write); newleaf->write(to_write.data(), GetParam().offset, GetParam().count);
return newleaf->key(); return newleaf->key();
} }
void EXPECT_DATA_READS_AS(const Data &expected, const DataNode &leaf, off_t offset, size_t count) { void EXPECT_DATA_READS_AS(const Data &expected, const DataLeafNode &leaf, off_t offset, size_t count) {
Data read(count); Data read(count);
leaf.read(offset, count, &read); leaf.read(read.data(), offset, count);
EXPECT_DATA_EQ(expected, read); EXPECT_DATA_EQ(expected, read);
} }
void EXPECT_DATA_READS_AS_OUTSIDE_OF(const Data &expected, const DataNode &leaf, off_t start, size_t count) { void EXPECT_DATA_READS_AS_OUTSIDE_OF(const Data &expected, const DataLeafNode &leaf, off_t start, size_t count) {
Data begin(start); Data begin(start);
Data end(GetParam().leafsize - count - start); Data end(GetParam().leafsize - count - start);
@ -319,26 +318,26 @@ public:
EXPECT_DATA_READS_AS(end, leaf, start + count, end.size()); EXPECT_DATA_READS_AS(end, leaf, start + count, end.size());
} }
void EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(const DataNode &leaf, off_t start, size_t count) { void EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(const DataLeafNode &leaf, off_t start, size_t count) {
Data ZEROES(GetParam().leafsize); Data ZEROES(GetParam().leafsize);
ZEROES.FillWithZeroes(); ZEROES.FillWithZeroes();
EXPECT_DATA_READS_AS_OUTSIDE_OF(ZEROES, leaf, start, count); EXPECT_DATA_READS_AS_OUTSIDE_OF(ZEROES, leaf, start, count);
} }
}; };
INSTANTIATE_TEST_CASE_P(DataLeafNodeDataTest, DataLeafNodeDataTest, Values( INSTANTIATE_TEST_CASE_P(DataLeafNodeDataTest, DataLeafNodeDataTest, Values(
DataRange(DataLeafNode::MAX_STORED_BYTES, 0, DataLeafNode::MAX_STORED_BYTES), // full size leaf, access beginning to end DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf(), 0, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()), // full size leaf, access beginning to end
DataRange(DataLeafNode::MAX_STORED_BYTES, 100, DataLeafNode::MAX_STORED_BYTES-200), // full size leaf, access middle to middle DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf(), 100, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-200), // full size leaf, access middle to middle
DataRange(DataLeafNode::MAX_STORED_BYTES, 0, DataLeafNode::MAX_STORED_BYTES-100), // full size leaf, access beginning to middle DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf(), 0, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100), // full size leaf, access beginning to middle
DataRange(DataLeafNode::MAX_STORED_BYTES, 100, DataLeafNode::MAX_STORED_BYTES-100), // full size leaf, access middle to end DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf(), 100, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100), // full size leaf, access middle to end
DataRange(DataLeafNode::MAX_STORED_BYTES-100, 0, DataLeafNode::MAX_STORED_BYTES-100), // non-full size leaf, access beginning to end DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100, 0, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100), // non-full size leaf, access beginning to end
DataRange(DataLeafNode::MAX_STORED_BYTES-100, 100, DataLeafNode::MAX_STORED_BYTES-300), // non-full size leaf, access middle to middle DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100, 100, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-300), // non-full size leaf, access middle to middle
DataRange(DataLeafNode::MAX_STORED_BYTES-100, 0, DataLeafNode::MAX_STORED_BYTES-200), // non-full size leaf, access beginning to middle DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100, 0, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-200), // non-full size leaf, access beginning to middle
DataRange(DataLeafNode::MAX_STORED_BYTES-100, 100, DataLeafNode::MAX_STORED_BYTES-200) // non-full size leaf, access middle to end DataRange(DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-100, 100, DataLeafNodeTest::LAYOUT.maxBytesPerLeaf()-200) // non-full size leaf, access middle to end
)); ));
TEST_P(DataLeafNodeDataTest, WriteAndReadImmediately) { TEST_P(DataLeafNodeDataTest, WriteAndReadImmediately) {
leaf->resize(GetParam().leafsize); leaf->resize(GetParam().leafsize);
leaf->write(GetParam().offset, GetParam().count, this->foregroundData); leaf->write(this->foregroundData.data(), GetParam().offset, GetParam().count);
EXPECT_DATA_READS_AS(this->foregroundData, *leaf, GetParam().offset, GetParam().count); EXPECT_DATA_READS_AS(this->foregroundData, *leaf, GetParam().offset, GetParam().count);
EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(*leaf, GetParam().offset, GetParam().count); EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(*leaf, GetParam().offset, GetParam().count);
@ -347,17 +346,16 @@ TEST_P(DataLeafNodeDataTest, WriteAndReadImmediately) {
TEST_P(DataLeafNodeDataTest, WriteAndReadAfterLoading) { TEST_P(DataLeafNodeDataTest, WriteAndReadAfterLoading) {
Key key = CreateLeafWriteToItAndReturnKey(this->foregroundData); Key key = CreateLeafWriteToItAndReturnKey(this->foregroundData);
auto loaded_leaf = nodeStore->load(key); auto loaded_leaf = LoadLeafNode(key);
EXPECT_DATA_READS_AS(this->foregroundData, *loaded_leaf, GetParam().offset, GetParam().count); EXPECT_DATA_READS_AS(this->foregroundData, *loaded_leaf, GetParam().offset, GetParam().count);
EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(*loaded_leaf, GetParam().offset, GetParam().count); EXPECT_DATA_IS_ZEROES_OUTSIDE_OF(*loaded_leaf, GetParam().offset, GetParam().count);
} }
TEST_P(DataLeafNodeDataTest, OverwriteAndRead) { TEST_P(DataLeafNodeDataTest, OverwriteAndRead) {
leaf->resize(GetParam().leafsize); leaf->resize(GetParam().leafsize);
leaf->write(0, GetParam().leafsize, this->backgroundData); leaf->write(this->backgroundData.data(), 0, GetParam().leafsize);
leaf->write(GetParam().offset, GetParam().count, this->foregroundData); leaf->write(this->foregroundData.data(), GetParam().offset, GetParam().count);
EXPECT_DATA_READS_AS(this->foregroundData, *leaf, GetParam().offset, GetParam().count); EXPECT_DATA_READS_AS(this->foregroundData, *leaf, GetParam().offset, GetParam().count);
EXPECT_DATA_READS_AS_OUTSIDE_OF(this->backgroundData, *leaf, GetParam().offset, GetParam().count); EXPECT_DATA_READS_AS_OUTSIDE_OF(this->backgroundData, *leaf, GetParam().offset, GetParam().count);
} }
*/