hardcoresushi/libcryfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

TODOs

Browse Source
This commit is contained in:
Sebastian Messmer 2015-05-06 16:16:18 +02:00
parent fdcd56401a
commit 535bfc1634
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
implementations/encrypted/EncryptedBlock.h
View File

@ -16,6 +16,8 @@ namespace blockstore {
namespace encrypted { namespace encrypted {
template<class Cipher> class EncryptedBlockStore; template<class Cipher> class EncryptedBlockStore;
//TODO Test EncryptedBlock
template<class Cipher> template<class Cipher>
class EncryptedBlock: public Block { class EncryptedBlock: public Block {
public: public:

3
implementations/encrypted/EncryptedBlockStore.h
View File

@ -16,6 +16,7 @@ class EncryptedBlockStore: public BlockStore {
public: public:
EncryptedBlockStore(std::unique_ptr<BlockStore> baseBlockStore, const typename Cipher::EncryptionKey &encKey); EncryptedBlockStore(std::unique_ptr<BlockStore> baseBlockStore, const typename Cipher::EncryptionKey &encKey);
//TODO Are createKey() tests included in generic BlockStoreTest? If not, add it!
Key createKey() override; Key createKey() override;
std::unique_ptr<Block> tryCreate(const Key &key, cpputils::Data data) override; std::unique_ptr<Block> tryCreate(const Key &key, cpputils::Data data) override;
std::unique_ptr<Block> load(const Key &key) override; std::unique_ptr<Block> load(const Key &key) override;
@ -46,6 +47,7 @@ Key EncryptedBlockStore<Cipher>::createKey() {
template<class Cipher> template<class Cipher>
std::unique_ptr<Block> EncryptedBlockStore<Cipher>::tryCreate(const Key &key, cpputils::Data data) { std::unique_ptr<Block> EncryptedBlockStore<Cipher>::tryCreate(const Key &key, cpputils::Data data) {
//TODO Test that this returns nullptr when base blockstore returns nullptr (for all pass-through-blockstores)
return EncryptedBlock<Cipher>::TryCreateNew(_baseBlockStore.get(), key, std::move(data), _encKey); return EncryptedBlock<Cipher>::TryCreateNew(_baseBlockStore.get(), key, std::move(data), _encKey);
} }
@ -53,6 +55,7 @@ template<class Cipher>
std::unique_ptr<Block> EncryptedBlockStore<Cipher>::load(const Key &key) { std::unique_ptr<Block> EncryptedBlockStore<Cipher>::load(const Key &key) {
auto block = _baseBlockStore->load(key); auto block = _baseBlockStore->load(key);
if (block.get() == nullptr) { if (block.get() == nullptr) {
//TODO Test this path (for all pass-through-blockstores)
return nullptr; return nullptr;
} }
return EncryptedBlock<Cipher>::TryDecrypt(std::move(block), _encKey); return EncryptedBlock<Cipher>::TryDecrypt(std::move(block), _encKey);