From a68446f98386382d93e9650b16bd89ce9fc4a0e0 Mon Sep 17 00:00:00 2001 From: Sebastian Messmer Date: Fri, 11 Dec 2015 12:31:57 +0100 Subject: [PATCH] Comment out failing test cases instead of DISABLING them. Disabling is reserved for working, but slow tests --- test/fuse/closeFile/FuseCloseTest.cpp | 4 ++-- test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp | 4 ++-- test/impl/FuseOpenFileListTest.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/fuse/closeFile/FuseCloseTest.cpp b/test/fuse/closeFile/FuseCloseTest.cpp index 4fa62cec..acfc2121 100644 --- a/test/fuse/closeFile/FuseCloseTest.cpp +++ b/test/fuse/closeFile/FuseCloseTest.cpp @@ -78,7 +78,7 @@ INSTANTIATE_TEST_CASE_P(FuseCloseTest, FuseCloseTest, Values(0, 1, 2, 100, 1024* //TODO Figure out what's wrong and enable this test //Disabled, because it is flaky. libfuse seems to not send the release() event sometimes. -TEST_P(FuseCloseTest, DISABLED_CloseFile) { +/*TEST_P(FuseCloseTest, CloseFile) { Barrier barrier; ReturnIsFileOnLstat(FILENAME); @@ -96,4 +96,4 @@ TEST_P(FuseCloseTest, DISABLED_CloseFile) { // Wait, until fuse release() was called, so we can check for the function call expectation. barrier.WaitAtMost(seconds(10)); -} +}*/ diff --git a/test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp b/test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp index b351c126..400f2f4e 100644 --- a/test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp +++ b/test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp @@ -11,7 +11,7 @@ class FuseCreateAndOpenFlagsTest: public FuseCreateAndOpenTest, public WithParam INSTANTIATE_TEST_CASE_P(FuseCreateAndOpenFlagsTest, FuseCreateAndOpenFlagsTest, Values(O_RDWR, O_RDONLY, O_WRONLY)); //TODO Disabled because it doesn't seem to work. Fuse doesn't seem to pass flags to create(). Why? -TEST_P(FuseCreateAndOpenFlagsTest, DISABLED_testFlags) { +/*TEST_P(FuseCreateAndOpenFlagsTest, testFlags) { ReturnDoesntExistOnLstat(FILENAME); EXPECT_CALL(fsimpl, createAndOpenFile(StrEq(FILENAME), OpenFlagsEq(GetParam()), _, _)) .Times(1).WillOnce(Return(0)); @@ -19,4 +19,4 @@ TEST_P(FuseCreateAndOpenFlagsTest, DISABLED_testFlags) { ReturnIsFileOnFstat(0); CreateAndOpenFile(FILENAME, GetParam()); -} +}*/ diff --git a/test/impl/FuseOpenFileListTest.cpp b/test/impl/FuseOpenFileListTest.cpp index 148b7f43..d6c7401c 100644 --- a/test/impl/FuseOpenFileListTest.cpp +++ b/test/impl/FuseOpenFileListTest.cpp @@ -89,7 +89,7 @@ TEST_F(FuseOpenFileListTest, Open3AndGet) { } //TODO Test case fails. Disabled it. Figure out why and reenable. -TEST_F(FuseOpenFileListTest, DISABLED_DestructOnClose) { +/*TEST_F(FuseOpenFileListTest, DestructOnClose) { int id = open(); MockOpenFile *openFile = dynamic_cast(list.get(id)); @@ -97,7 +97,7 @@ TEST_F(FuseOpenFileListTest, DISABLED_DestructOnClose) { EXPECT_FALSE(openFile->destructed); list.close(id); EXPECT_TRUE(openFile->destructed); -} +}*/ TEST_F(FuseOpenFileListTest, GetClosedItemOnEmptyList) { int id = open();