From 4d79fba2853b7d0b5f4cafc4aab55b1c448282e3 Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Wed, 20 Apr 2016 22:47:31 +0200 Subject: [PATCH] prelloc: warn and continue if fallocate(2) is not supported This makes gocryptfs work at all on ZFS. See https://github.com/rfjakob/gocryptfs/issues/22 . --- internal/fusefrontend/compat_linux.go | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/internal/fusefrontend/compat_linux.go b/internal/fusefrontend/compat_linux.go index 4108792..8a20d5d 100644 --- a/internal/fusefrontend/compat_linux.go +++ b/internal/fusefrontend/compat_linux.go @@ -1,6 +1,13 @@ package fusefrontend -import "syscall" +import ( + "sync" + "syscall" +) + +import "github.com/rfjakob/gocryptfs/internal/toggledlog" + +var preallocWarn sync.Once // prealloc - preallocate space without changing the file size. This prevents // us from running out of space in the middle of an operation. @@ -13,6 +20,16 @@ func prealloc(fd int, off int64, len int64) (err error) { // signal and we should try again. continue } + if err == syscall.EOPNOTSUPP { + // ZFS does not support fallocate which caused gocryptfs to abort + // every write operation: https://github.com/rfjakob/gocryptfs/issues/22 + preallocWarn.Do(func() { + toggledlog.Warn.Printf("Warning: The underlying filesystem " + + "does not support fallocate(2). gocryptfs will continue working " + + "but is no longer resistant against out-of-space errors.\n") + }) + return nil + } return err } }