From 8945f4db95ec75dd1f9de763ae249d9e433d3732 Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Sat, 10 Dec 2016 15:01:00 +0100 Subject: [PATCH] ctlsock: add a note about Accept() throwing errors on Close() --- internal/ctlsock/ctlsock_serve.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/ctlsock/ctlsock_serve.go b/internal/ctlsock/ctlsock_serve.go index 45b1e5b..a8e6766 100644 --- a/internal/ctlsock/ctlsock_serve.go +++ b/internal/ctlsock/ctlsock_serve.go @@ -60,6 +60,9 @@ func (ch *ctlSockHandler) acceptLoop() { for { conn, err := ch.socket.Accept() if err != nil { + // TODO Can this warning trigger when the socket it closed on + // program exit? I have never observed it, but the documentation + // says that Close() unblocks Accept(). tlog.Warn.Printf("ctlsock: Accept error: %v", err) break }