hardcoresushi/libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

syscallcompat: Fix Fchownat syscall wrapper on darwin

Browse Source 
* Acquire the lock before reading the current directory
* Fix a file descriptor leak
This commit is contained in:
Sebastian Lackner 2017-11-28 00:11:15 +01:00 committed by rfjakob
parent 72b975867a
commit 8c5069c637
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/syscallcompat/sys_darwin.go
View File

@ -134,12 +134,13 @@ func Dup3(oldfd int, newfd int, flags int) (err error) {
// Poor man's Fchownat. // Poor man's Fchownat.
func Fchownat(dirfd int, path string, uid int, gid int, flags int) (err error) { func Fchownat(dirfd int, path string, uid int, gid int, flags int) (err error) {
chdirMutex.Lock()
defer chdirMutex.Unlock()
cwd, err := syscall.Open(".", syscall.O_RDONLY, 0) cwd, err := syscall.Open(".", syscall.O_RDONLY, 0)
if err != nil { if err != nil {
return err return err
} }
chdirMutex.Lock() defer syscall.Close(cwd)
defer chdirMutex.Unlock()
err = syscall.Fchdir(dirfd) err = syscall.Fchdir(dirfd)
if err != nil { if err != nil {
return err return err