hardcoresushi/libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Downgrade "gocryptfs.diriv not found" warning if the directory was deleted

Browse Source 
The directory may have been concurrently deleted or moved. Failure to
read the diriv is not an error in that case.

Downgrading the message to debug.
This commit is contained in:
Jakob Unterwurzacher 2016-01-24 19:40:53 +01:00
parent 65b8d5bc46
commit 8fb32aab68
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
cryptfs/names_diriv.go
View File

@ -1,6 +1,7 @@
package cryptfs package cryptfs
import ( import (
"os"
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"path/filepath" "path/filepath"
@ -49,16 +50,24 @@ func (c *DirIVCache) Clear() {
} }
// readDirIV - read the "gocryptfs.diriv" file from "dir" (absolute ciphertext path) // readDirIV - read the "gocryptfs.diriv" file from "dir" (absolute ciphertext path)
func (be *CryptFS) ReadDirIV(dir string) (iv []byte, err error) { func (be *CryptFS) ReadDirIV(dir string) (iv []byte, readErr error) {
ivfile := filepath.Join(dir, DIRIV_FILENAME) ivfile := filepath.Join(dir, DIRIV_FILENAME)
Debug.Printf("readDirIV: reading %s\n", ivfile) Debug.Printf("ReadDirIV: reading %s\n", ivfile)
iv, err = ioutil.ReadFile(ivfile) iv, readErr = ioutil.ReadFile(ivfile)
if err != nil { if readErr != nil {
Warn.Printf("readDirIV: %v\n", err) // The directory may have been concurrently deleted or moved. Failure to
return nil, err // read the diriv is not an error in that case.
_, statErr := os.Stat(dir)
if os.IsNotExist(statErr) {
Debug.Printf("ReadDirIV: Dir %s was deleted under our feet", dir)
} else {
// This should not happen
Warn.Printf("ReadDirIV: Dir exists but diriv does not: %v\n", readErr)
}
return nil, readErr
} }
if len(iv) != DIRIV_LEN { if len(iv) != DIRIV_LEN {
return nil, fmt.Errorf("readDirIV: Invalid length %d\n", len(iv)) return nil, fmt.Errorf("ReadDirIV: Invalid length %d\n", len(iv))
} }
return iv, nil return iv, nil
} }
@ -73,7 +82,7 @@ func WriteDirIV(dir string) error {
return ioutil.WriteFile(file, iv, 0444) return ioutil.WriteFile(file, iv, 0444)
} }
// EncryptPathDirIV - encrypt path using CBC or EME with DirIV // EncryptPathDirIV - encrypt path using EME with DirIV
func (be *CryptFS) EncryptPathDirIV(plainPath string, rootDir string, eme bool) (cipherPath string, err error) { func (be *CryptFS) EncryptPathDirIV(plainPath string, rootDir string, eme bool) (cipherPath string, err error) {
// Empty string means root directory // Empty string means root directory
if plainPath == "" { if plainPath == "" {
@ -109,7 +118,7 @@ func (be *CryptFS) EncryptPathDirIV(plainPath string, rootDir string, eme bool)
return cipherPath, nil return cipherPath, nil
} }
// DecryptPathDirIV - encrypt path using CBC or EME with DirIV // DecryptPathDirIV - decrypt path using EME with DirIV
func (be *CryptFS) DecryptPathDirIV(encryptedPath string, rootDir string, eme bool) (string, error) { func (be *CryptFS) DecryptPathDirIV(encryptedPath string, rootDir string, eme bool) (string, error) {
var wd = rootDir var wd = rootDir
var plainNames []string var plainNames []string