hardcoresushi/libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Omit syscall.O_RDONLY flag when passing O_PATH.

Browse Source 
When O_PATH is specified in flags, flag bits other than O_CLOEXEC, O_DIRECTORY,
and O_NOFOLLOW are ignored.
This commit is contained in:
Sebastian Lackner 2019-01-03 18:11:07 +01:00 committed by rfjakob
parent 0414ef2572
commit a1ba4b6576
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
init_dir.go
View File

@ -99,7 +99,7 @@ func initDir(args *argContainer) {
// in the root dir // in the root dir
if !args.plaintextnames && !args.reverse { if !args.plaintextnames && !args.reverse {
// Open cipherdir (following symlinks) // Open cipherdir (following symlinks)
dirfd, err := syscall.Open(args.cipherdir, syscall.O_RDONLY|syscall.O_DIRECTORY|syscallcompat.O_PATH, 0) dirfd, err := syscall.Open(args.cipherdir, syscall.O_DIRECTORY|syscallcompat.O_PATH, 0)
if err == nil { if err == nil {
err = nametransform.WriteDirIVAt(dirfd) err = nametransform.WriteDirIVAt(dirfd)
syscall.Close(dirfd) syscall.Close(dirfd)

4
internal/fusefrontend/openbackingdir.go
View File

@ -42,7 +42,7 @@ func (fs *FS) openBackingDir(relPath string) (dirfd int, cName string, err error
return dirfd, cName, nil return dirfd, cName, nil
} }
// Open cipherdir (following symlinks) // Open cipherdir (following symlinks)
dirfd, err = syscall.Open(fs.args.Cipherdir, syscall.O_RDONLY|syscall.O_DIRECTORY|syscallcompat.O_PATH, 0) dirfd, err = syscall.Open(fs.args.Cipherdir, syscall.O_DIRECTORY|syscallcompat.O_PATH, 0)
if err != nil { if err != nil {
return -1, "", err return -1, "", err
} }
@ -65,7 +65,7 @@ func (fs *FS) openBackingDir(relPath string) (dirfd int, cName string, err error
break break
} }
// Not the last part? Descend into next directory. // Not the last part? Descend into next directory.
dirfd2, err := syscallcompat.Openat(dirfd, cName, syscall.O_RDONLY|syscall.O_NOFOLLOW|syscall.O_DIRECTORY|syscallcompat.O_PATH, 0) dirfd2, err := syscallcompat.Openat(dirfd, cName, syscall.O_NOFOLLOW|syscall.O_DIRECTORY|syscallcompat.O_PATH, 0)
syscall.Close(dirfd) syscall.Close(dirfd)
if err != nil { if err != nil {
return -1, "", err return -1, "", err

2
tests/test_helpers/helpers.go
View File

@ -114,7 +114,7 @@ func ResetTmpDir(createDirIV bool) {
} }
if createDirIV { if createDirIV {
// Open cipherdir (following symlinks) // Open cipherdir (following symlinks)
dirfd, err := syscall.Open(DefaultCipherDir, syscall.O_RDONLY|syscall.O_DIRECTORY|syscallcompat.O_PATH, 0) dirfd, err := syscall.Open(DefaultCipherDir, syscall.O_DIRECTORY|syscallcompat.O_PATH, 0)
if err == nil { if err == nil {
err = nametransform.WriteDirIVAt(dirfd) err = nametransform.WriteDirIVAt(dirfd)
syscall.Close(dirfd) syscall.Close(dirfd)