hardcoresushi/libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

xattr: return EOPNOTSUPP instead of ENODATA in GetXattr

Browse Source 
Reading system.posix_acl_access and system.posix_acl_default
should return EOPNOTSUPP to inform user-space that we do not
support ACLs.

xftestest essientially does

	chacl -l | grep "Operation not supported"

to determine if the filesystem supports ACLs, and used to
wrongly believe that gocryptfs does.
This commit is contained in:
Jakob Unterwurzacher 2018-06-12 21:07:00 +02:00
parent bde7ba57b0
commit bfa50517e9
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/fusefrontend/xattr.go
View File

@ -13,7 +13,10 @@ import (
"github.com/rfjakob/gocryptfs/internal/tlog" "github.com/rfjakob/gocryptfs/internal/tlog"
) )
const _EOPNOTSUPP = fuse.Status(syscall.EOPNOTSUPP)
// xattr names are encrypted like file names, but with a fixed IV. // xattr names are encrypted like file names, but with a fixed IV.
// Padded with "_xx" for length 16.
var xattrNameIV = []byte("xattr_name_iv_xx") var xattrNameIV = []byte("xattr_name_iv_xx")
// We store encrypted xattrs under this prefix plus the base64-encoded // We store encrypted xattrs under this prefix plus the base64-encoded
@ -27,9 +30,7 @@ func (fs *FS) GetXAttr(path string, attr string, context *fuse.Context) ([]byte,
return nil, fuse.EPERM return nil, fuse.EPERM
} }
if disallowedXAttrName(attr) { if disallowedXAttrName(attr) {
// "ls -l" queries security.selinux, system.posix_acl_access, system.posix_acl_default return nil, _EOPNOTSUPP
// and throws error messages if it gets something else than ENODATA.
return nil, fuse.ENODATA
} }
cAttr := fs.encryptXattrName(attr) cAttr := fs.encryptXattrName(attr)
cPath, err := fs.getBackingPath(path) cPath, err := fs.getBackingPath(path)
@ -48,8 +49,6 @@ func (fs *FS) GetXAttr(path string, attr string, context *fuse.Context) ([]byte,
return data, fuse.OK return data, fuse.OK
} }
const _EOPNOTSUPP = fuse.Status(syscall.EOPNOTSUPP)
// SetXAttr implements pathfs.Filesystem. // SetXAttr implements pathfs.Filesystem.
func (fs *FS) SetXAttr(path string, attr string, data []byte, flags int, context *fuse.Context) fuse.Status { func (fs *FS) SetXAttr(path string, attr string, data []byte, flags int, context *fuse.Context) fuse.Status {
if fs.isFiltered(path) { if fs.isFiltered(path) {