hardcoresushi
/
libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity
1,932 Commits 2 Branches 0 Tags 6 MiB
Commit Graph

84 Commits

Author SHA1 Message Date
Jakob Unterwurzacher 2620cad0dc tests/matrix: test xchacha with and without openssl 2021-09-08 20:34:01 +02:00
Jakob Unterwurzacher 34d8a498c4 Unbreak hyperlinks broken by go mod v2 conversion 
Commit

  69d88505fd go mod: declare module version v2

translated all instances of "github.com/rfjakob/gocryptfs/" to
"github.com/rfjakob/gocryptfs/v2/".

Unfortunately, this included hyperlinks.

Unbreak the hyperlinks like this:

  find . -name \*.go | xargs sed -i s%https://github.com/rfjakob/gocryptfs/v2/%https://github.com/rfjakob/gocryptfs/v2/%
 2021-08-30 11:31:01 +02:00
Jakob Unterwurzacher 2fb1d52746 tests/matrix: add -xchacha test 2021-08-23 16:00:41 +02:00
Jakob Unterwurzacher 69d88505fd go mod: declare module version v2 
Our git version is v2+ for some time now, but go.mod
still declared v1. Hopefully making both match makes
https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work.

All the import paths have been fixed like this:

  find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/%
 2021-08-23 15:05:15 +02:00
Jakob Unterwurzacher 195d9d18a9 Implement -deterministic-names: extended -zerodiriv 
-deterministc-names uses all-zero dirivs but does not write
them to disk anymore.
 2021-08-20 10:58:42 +02:00
Jakob Unterwurzacher be2bd4eec7 golangci-lint: fix issues found by "unused" and "deadcode" 
Except xattrSupported, this is a false positive.

$ golangci-lint run --disable-all --enable unused --enable deadcode
gocryptfs-xray/xray_main.go:24:5: `GitVersionFuse` is unused (deadcode)
var GitVersionFuse = "[GitVersionFuse not set - please compile using ./build.bash]"
    ^
tests/symlink_race/main.go:47:6: `chmodLoop` is unused (deadcode)
func chmodLoop() {
     ^
internal/readpassword/extpass_test.go:11:5: `testPw` is unused (deadcode)
var testPw = []byte("test")
    ^
tests/reverse/xattr_test.go:13:6: func `xattrSupported` is unused (unused)
func xattrSupported(path string) bool {
     ^
internal/fusefrontend_reverse/rpath.go:20:22: func `(*RootNode).abs` is unused (unused)
func (rfs *RootNode) abs(relPath string, err error) (string, error) {
                     ^
tests/matrix/matrix_test.go:310:6: `sContains` is unused (deadcode)
func sContains(haystack []string, needle string) bool {
 2021-08-19 08:34:49 +02:00
Jakob Unterwurzacher eecbcbb090 tests: matrix: add TestPwd 
https://github.com/rfjakob/gocryptfs/issues/584
 2021-07-31 13:23:05 +02:00
Jakob Unterwurzacher 17f859d3c4 fusefronted: report plaintext size on symlink creation 
gocryptfs 2.0 introduced the regression that the size
reported at symlink creation was the ciphertext size,
which is wrong.

Report the plaintext size.

Fixes https://github.com/rfjakob/gocryptfs/issues/574
 2021-06-06 19:22:16 +02:00
Jakob Unterwurzacher 692a79461a tests: matrix: add -sharestorage to test matrix 
Currently fails like this:

=== RUN   TestRmwRace
doRead 0: corrupt block #0: cipher: message authentication failed
-wpanic turns this warning into a panic: doRead 0: corrupt block #0: cipher: message authentication failed
panic: -wpanic turns this warning into a panic: doRead 0: corrupt block #0: cipher: message authentication failed

goroutine 1293 [running]:
log.(*Logger).Panic(0xc00011c230, 0xc0003b17c8, 0x1, 0x1)
	log/log.go:224 +0xac
github.com/rfjakob/gocryptfs/internal/tlog.(*toggledLogger).Printf(0xc00007a780, 0x55a821a766a1, 0x20, 0xc0003b19f0, 0x3, 0x3)
	github.com/rfjakob/gocryptfs/internal/tlog/log.go:78 +0x1ef
github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).doRead(0xc0001ff420, 0x0, 0x0, 0x0, 0x0, 0x1000, 0x0, 0x1, 0xc000880000, 0x1020)
	github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:201 +0x8c9
github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).doWrite(0xc0001ff420, 0xc000248428, 0x10, 0x30, 0xff0, 0x3, 0x18)
	github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:291 +0xc9e
github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).Write(0xc0001ff420, 0x55a821b306a0, 0xc000fbde90, 0xc000248428, 0x10, 0x30, 0xff0, 0x7f4a00000000, 0x0)
	github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:378 +0x25e
github.com/hanwen/go-fuse/v2/fs.(*rawBridge).Write(0xc000168140, 0xc000096000, 0xc0002483d8, 0xc000248428, 0x10, 0x30, 0x55a821ad40e0)
	github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fs/bridge.go:819 +0x26d
github.com/hanwen/go-fuse/v2/fuse.doWrite(0xc000170160, 0xc000248240)
	github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/opcode.go:191 +0x6f
github.com/hanwen/go-fuse/v2/fuse.(*Server).handleRequest(0xc000170160, 0xc000248240, 0xc000000000)
	github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:472 +0x2be
github.com/hanwen/go-fuse/v2/fuse.(*Server).loop(0xc000170160, 0xc000cd4101)
	github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:445 +0x198
created by github.com/hanwen/go-fuse/v2/fuse.(*Server).readRequest
	github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:312 +0x41d
    matrix_test.go:354: Write failed
 2021-03-20 18:27:34 +01:00
Jakob Unterwurzacher 58a2726977 v2api/reverse: implement Statfs 2020-08-16 19:41:00 +02:00
Jakob Unterwurzacher f270135c16 test_helper: VerifyExistence: don't panic 
Instead bubble up the error to the testing object.
 2020-08-15 15:39:08 +02:00
Jakob Unterwurzacher d7db071528 tests: TestMagicNames: add warmup rounds 
Chasing a bug that seems to have nothing to do
with magic names, as it already triggers during
warmup:

--- FAIL: TestMagicNames (0.00s)
    matrix_test.go:773: Testing n="warmup1"
    matrix_test.go:773: Testing n="warmup2"
    matrix_test.go:820: no such file or directory
 2020-07-12 21:00:52 +02:00
Jakob Unterwurzacher f11432d02a v2api: Getattr: use file handle if passed 2020-07-12 15:08:17 +02:00
Jakob Unterwurzacher c19baa10f8 tests: use t.Name() 
We did not use t.Name() as it was not available
before Go 1.8. Now the oldest Go version we support is
Go 1.11, so we can use it.
 2020-05-09 15:42:57 +02:00
Jakob Unterwurzacher 6eca07e36e tests: randomize data in testWriteN 
Just writing zeros carries the risk of not detecting
wrongly created file holes. Write random data instead.
 2020-02-15 21:56:08 +01:00
Jakob Unterwurzacher 1fb18f4a9e tests: filter leaked fds by prefix 
When running

  $ go test ./tests/matrix/

in isolation, it failed like this:

  fd leak? before, after:
  [0r=/dev/null 3w=/dev/null 5r=/proc/8078/fd (hidden:4)]
  [0r=/dev/null 3w=/dev/null 5w=/tmp/go-build366655199/b001/testlog.txt 7r=/proc/8078/fd (hidden:4)]

Filter by prefix to get rid of this spurious test failure.
 2019-10-06 19:37:51 +02:00
Jakob Unterwurzacher d361f6e35b tests: clarify which process seems to be leaking fds 
The tests check if they leak fds themselves, but we also
check if gocryptfs leaks fds. Clarify what is what in the
error message.
 2019-10-06 18:48:09 +02:00
Jakob Unterwurzacher 7eba4f0788 tests: matrix: test -serialize_reads 
Test if https://github.com/rfjakob/gocryptfs/pull/413 works
as intended.
 2019-09-01 12:51:42 +02:00
Jakob Unterwurzacher 24036ab89f tests: speed up new tests a little 
Before: ok  	github.com/rfjakob/gocryptfs/tests/matrix	18.560s
After:  ok  	github.com/rfjakob/gocryptfs/tests/matrix	13.425s
 2019-04-08 20:34:24 +02:00
Jakob Unterwurzacher d851cf8055 tests: add TestConcurrentReadCreate, move to new file 
https://github.com/rfjakob/gocryptfs/issues/363
 2019-04-08 20:27:13 +02:00
Jakob Unterwurzacher d22ccf68b2 tests: add TestConcurrentReadWrite 
Another attempt to find out what is going on behind
https://github.com/rfjakob/gocryptfs/issues/363
 2019-04-08 20:27:13 +02:00
Jakob Unterwurzacher 311c34af4b tests: add additional TestWrite10Tight test 
Try to find out what goes wrong in
https://github.com/rfjakob/gocryptfs/issues/363
 2019-04-08 20:27:13 +02:00
Jakob Unterwurzacher 173218895c tests: fix compile error in matrix_test.go 
Error was:

tests/matrix/matrix_test.go:101:9: no new variables on left side of :=
 2019-02-17 17:25:41 +01:00
Jakob Unterwurzacher 179471b648 ParseHeader: print hexdump on error 
Should help debugging https://github.com/rfjakob/gocryptfs/issues/363
 2019-02-17 17:13:20 +01:00
Jakob Unterwurzacher 19cb6d046a nametransform: reject names longer than 255 chars 
Looks like we allowed creating longer names by accident.
Fix that, and add a test that verifies it.
 2019-02-17 17:05:05 +01:00
Jakob Unterwurzacher fab585ec01 tests: matrix: split out directory tests into their own file 
matrix_test.go is already too big.
 2019-01-20 13:41:20 +01:00
Jakob Unterwurzacher 20140e24ed tests: reduce noise on MacOS 
This should get rid of

    Openat: O_NOFOLLOW missing: flags = 0x0
    Fchmodat: adding missing AT_SYMLINK_NOFOLLOW flag
    sys_common_test.go:203: chmod on symlink should have failed, but did not. New mode=0333
    UnmountErr: "[...]/057376762.mnt" was not found in MountInfo, cannot check for FD leak

and add some context to

    --- FAIL: TestUtimesNano (0.00s)
    matrix_test.go:628: no such file or directory

See https://github.com/rfjakob/gocryptfs/pull/343#issuecomment-453888006
for full test output
 2019-01-14 22:11:15 +01:00
Jakob Unterwurzacher c83aa417e4 tests: move fallocate tests to its own file 
matrix_test.go is already too big.
 2019-01-06 20:31:41 +01:00
Jakob Unterwurzacher db425cab9e tests: TestFallocate: comment what "d" and "h" means 
Document what "d" and "h" means in the fancy ASCII diagrams.
https://github.com/rfjakob/gocryptfs/pull/326
 2019-01-06 12:49:27 +01:00
Jakob Unterwurzacher 887d5aa8e7 tests: teach ListFds() to check other processes 2019-01-01 20:05:38 +01:00
Jakob Unterwurzacher 817c485bb7 tests: save gocryptfs process id in test_helpers.MountPID 
This will allow to tests to monitor fd usage and maybe other things.
 2019-01-01 19:34:12 +01:00
Jakob Unterwurzacher ed6ed513d7 fusefrontend: make Access() symlink-safe. 
Make Access() symlink-safe through use of faccessat.
 2019-01-01 16:24:09 +01:00
Jakob Unterwurzacher 9e6ee47bc9 tests: detect and report chmod failures earlier 
Instead of reporting the consequence:

    matrix_test.go:906: modeHave 0664 != modeWant 0777

Report it if chmod itself fails, and also report the old file mode:

    matrix_test.go:901: chmod 000 -> 777 failed: bad file descriptor
 2018-09-22 13:39:17 +02:00
Jakob Unterwurzacher 84d6fafeca tests: restore Go 1.7 compatibility 
Go 1.7 does not have t.Name() yet.
 2018-09-08 18:19:53 +02:00
Jakob Unterwurzacher bc14f8dcb6 tests: add chmod test 
Makes sure we don't add regressions when fixing
https://github.com/rfjakob/gocryptfs/issues/259
 2018-09-08 17:00:23 +02:00
Jakob Unterwurzacher 21b5fae0e6 tests: restore TestUtimesNanoSymlink 
The function seems to have been renamed by 426b9536 by mistake.
Rename it back so the test is run again.
 2018-09-08 16:36:01 +02:00
Jakob Unterwurzacher 9d7392a5be tests: cli_test: fix fd leak 
One fd leak found in TestMountBackground.
 2018-04-07 15:46:41 +02:00
Jakob Unterwurzacher 22031d7e53 tests: matrix: check for fd leaks 
And fix two in test_helpers.Mount().

Leftover fds can cause an unmount failure like this later:
fusermount: failed to unmount /tmp/gocryptfs-test-parent/873632270/default-plain: Device or resource busy
so try to catch them early.
 2018-04-07 15:24:00 +02:00
Jakob Unterwurzacher 6e637f38ff tests: add a few explicit file Close() in matrix_test 
These can cause EBUSY errors when unmounting.
 2018-04-01 14:51:07 +02:00
Jakob Unterwurzacher 98f735ff6e tests: drop "-z" from fusermount to catch forgotten fds 
macos does not have lazy unmount, so let's not use it
on linux either.
If the unmount fails, run "lsof" to find the open file.

Also fix the first bug we found this way.
 2018-03-06 21:28:09 +01:00
Jakob Unterwurzacher 1789a5ea5b tests: matrix_test: skip cases when without_openssl is set 
Fixes test-without-openssl.bash.
 2018-03-05 23:11:27 +01:00
Jakob Unterwurzacher 870779ab1d macos: doTestUtimesNano: skip UTIME_OMIT and nanoseconds testcases 
Not supported on macos.

Beef up the first test case a little by using different second
values.
 2018-03-05 22:52:05 +01:00
Jakob Unterwurzacher 426b9536df tests: TestUtimesNano: replace ugly compareUtimes wrapper 2018-03-05 22:22:35 +01:00
Jakob Unterwurzacher 3064d72b97 tests: fix a few fd leaks 
We relied on the finalizer to close a few fds.
For some reason, this did not cause problems on Linux,
but on MacOS, it causes unmount failures:

umount(/private/tmp/gocryptfs-test-parent/194654785/default-plain): Resource busy -- try 'diskutil unmount'
 2018-03-05 22:00:59 +01:00
Jakob Unterwurzacher aa65091bb9 macos: skip TestUtimesNanoSymlink early 
Gets rid of the touch error message upon running the tests.
 2018-03-05 21:36:16 +01:00
Jakob Unterwurzacher 29496baa70 MacOS: skip TestUtimesNanoSymlink and TestUtimesNanoFd 
These cannot work on MacOS.
 2018-02-28 20:48:33 +01:00
Jakob Unterwurzacher 8951eb2472 fusefronted: add PlaintextNames special-cases for Create & Rename 
gocryptfs.longname.XXX files were considered magic in PlaintextNames
mode, which was wrong.

Fix that and add tests.

Fixes https://github.com/rfjakob/gocryptfs/issues/174
 2018-01-17 00:25:36 +01:00
Sebastian Lackner a24342f656 fusefrontend: Handle PlaintextNames mode in Link 
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning.

https://github.com/rfjakob/gocryptfs/issues/174
 2017-12-25 15:07:37 +01:00
Sebastian Lackner 2591900b69 fusefrontend: Handle PlaintextNames mode in Unlink 
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to delete any .name files.

Partially fixes https://github.com/rfjakob/gocryptfs/issues/174
 2017-11-28 09:28:06 +01:00
Sebastian Lackner 3f68b0c09a fusefrontend: Handle PlaintextNames mode in Mknod 
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to read the directory IV or to
create special .name files.

Partially fixes https://github.com/rfjakob/gocryptfs/issues/174
 2017-11-28 09:28:06 +01:00