4da245c69d
A file with a name of exactly 176 bytes length caused this error: ls: cannot access ./tmp/dsg/sXSGJLTuZuW1FarwIkJs0w/b6mGjdxIRpaeanTo0rbh0A/QjMRrQZC_4WLhmHI1UOBcA/gocryptfs.longname.QV-UipdDXeUVdl05WruoEzBNPrQCfpu6OzJL0_QnDKY: No such file or directory ls: cannot access ./tmp/dsg/sXSGJLTuZuW1FarwIkJs0w/b6mGjdxIRpaeanTo0rbh0A/QjMRrQZC_4WLhmHI1UOBcA/gocryptfs.longname.QV-UipdDXeUVdl05WruoEzBNPrQCfpu6OzJL0_QnDKY.name: No such file or directory -????????? ? ? ? ? ? gocryptfs.longname.QV-UipdDXeUVdl05WruoEzBNPrQCfpu6OzJL0_QnDKY -????????? ? ? ? ? ? gocryptfs.longname.QV-UipdDXeUVdl05WruoEzBNPrQCfpu6OzJL0_QnDKY.name Root cause was a wrong shortNameMax constant that failed to account for the obligatory padding byte. Fix the constant and also expand the TestLongnameStat test case to test ALL file name lengths from 1-255 bytes. Fixes https://github.com/rfjakob/gocryptfs/issues/143 .
112 lines
3.1 KiB
Go
112 lines
3.1 KiB
Go
package fusefrontend_reverse
|
|
|
|
import (
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/hanwen/go-fuse/fuse"
|
|
"github.com/hanwen/go-fuse/fuse/nodefs"
|
|
|
|
"github.com/rfjakob/gocryptfs/internal/nametransform"
|
|
"github.com/rfjakob/gocryptfs/internal/pathiv"
|
|
"github.com/rfjakob/gocryptfs/internal/tlog"
|
|
)
|
|
|
|
const (
|
|
// File names are padded to 16-byte multiples, encrypted and
|
|
// base64-encoded. We can encode at most 176 bytes to stay below the 255
|
|
// bytes limit:
|
|
// * base64(176 bytes) = 235 bytes
|
|
// * base64(192 bytes) = 256 bytes (over 255!)
|
|
// But the PKCS#7 padding is at least one byte. This means we can only use
|
|
// 175 bytes for the file name.
|
|
shortNameMax = 175
|
|
)
|
|
|
|
var longnameParentCache map[string]string
|
|
var longnameCacheLock sync.Mutex
|
|
|
|
// Very simple cache cleaner: Nuke it every hour
|
|
func longnameCacheCleaner() {
|
|
for {
|
|
time.Sleep(time.Hour)
|
|
longnameCacheLock.Lock()
|
|
longnameParentCache = map[string]string{}
|
|
longnameCacheLock.Unlock()
|
|
}
|
|
}
|
|
|
|
func initLongnameCache() {
|
|
if longnameParentCache != nil {
|
|
return
|
|
}
|
|
longnameParentCache = map[string]string{}
|
|
go longnameCacheCleaner()
|
|
}
|
|
|
|
// findLongnameParent converts "gocryptfs.longname.XYZ" to the plaintext name
|
|
func (rfs *ReverseFS) findLongnameParent(dir string, dirIV []byte, longname string) (plaintextName string, err error) {
|
|
longnameCacheLock.Lock()
|
|
hit := longnameParentCache[longname]
|
|
longnameCacheLock.Unlock()
|
|
if hit != "" {
|
|
return hit, nil
|
|
}
|
|
absDir := filepath.Join(rfs.args.Cipherdir, dir)
|
|
dirfd, err := os.Open(absDir)
|
|
if err != nil {
|
|
tlog.Warn.Printf("findLongnameParent: opendir failed: %v\n", err)
|
|
return "", err
|
|
}
|
|
dirEntries, err := dirfd.Readdirnames(-1)
|
|
if err != nil {
|
|
tlog.Warn.Printf("findLongnameParent: Readdirnames failed: %v\n", err)
|
|
return "", err
|
|
}
|
|
longnameCacheLock.Lock()
|
|
defer longnameCacheLock.Unlock()
|
|
for _, plaintextName = range dirEntries {
|
|
if len(plaintextName) <= shortNameMax {
|
|
continue
|
|
}
|
|
cName := rfs.nameTransform.EncryptName(plaintextName, dirIV)
|
|
if len(cName) <= syscall.NAME_MAX {
|
|
log.Panic("logic error or wrong shortNameMax constant?")
|
|
}
|
|
hName := rfs.nameTransform.HashLongName(cName)
|
|
longnameParentCache[hName] = plaintextName
|
|
if longname == hName {
|
|
hit = plaintextName
|
|
}
|
|
}
|
|
if hit == "" {
|
|
return "", syscall.ENOENT
|
|
}
|
|
return hit, nil
|
|
}
|
|
|
|
func (rfs *ReverseFS) newNameFile(relPath string) (nodefs.File, fuse.Status) {
|
|
dotName := filepath.Base(relPath) // gocryptfs.longname.XYZ.name
|
|
longname := dotName[:len(dotName)-len(nametransform.LongNameSuffix)] // gocryptfs.longname.XYZ
|
|
// cipher directory
|
|
cDir := nametransform.Dir(relPath)
|
|
// plain directory
|
|
pDir, err := rfs.decryptPath(cDir)
|
|
if err != nil {
|
|
return nil, fuse.ToStatus(err)
|
|
}
|
|
dirIV := pathiv.Derive(cDir, pathiv.PurposeDirIV)
|
|
// plain name
|
|
pName, err := rfs.findLongnameParent(pDir, dirIV, longname)
|
|
if err != nil {
|
|
return nil, fuse.ToStatus(err)
|
|
}
|
|
content := []byte(rfs.nameTransform.EncryptName(pName, dirIV))
|
|
parentFile := filepath.Join(rfs.args.Cipherdir, pDir, pName)
|
|
return rfs.newVirtualFile(content, parentFile, inoBaseNameFile)
|
|
}
|