libgocryptfs/internal
Jakob Unterwurzacher c86981342b golangci-lint: fix issues found by gosimple
Everything except the

	if err2.Err == syscall.EOPNOTSUPP

case. Gets too confusing when collapsed into a single line.

Issues were:

$ golangci-lint run --disable-all --enable gosimple
mount.go:473:2: S1008: should use 'return strings.HasPrefix(v, "fusermount version")' instead of 'if strings.HasPrefix(v, "fusermount version") { return true }; return false' (gosimple)
	if strings.HasPrefix(v, "fusermount version") {
	^
cli_args.go:258:5: S1002: should omit comparison to bool constant, can be simplified to `args.forcedecode` (gosimple)
	if args.forcedecode == true {
	   ^
cli_args.go:263:6: S1002: should omit comparison to bool constant, can be simplified to `args.aessiv` (gosimple)
		if args.aessiv == true {
		   ^
cli_args.go:267:6: S1002: should omit comparison to bool constant, can be simplified to `args.reverse` (gosimple)
		if args.reverse == true {
		   ^
internal/stupidgcm/stupidgcm.go:227:6: S1002: should omit comparison to bool constant, can be simplified to `g.forceDecode` (gosimple)
		if g.forceDecode == true {
		   ^
gocryptfs-xray/xray_tests/xray_test.go:23:5: S1004: should use !bytes.Equal(out, expected) instead (gosimple)
	if bytes.Compare(out, expected) != 0 {
	   ^
gocryptfs-xray/xray_tests/xray_test.go:40:5: S1004: should use !bytes.Equal(out, expected) instead (gosimple)
	if bytes.Compare(out, expected) != 0 {
	   ^
gocryptfs-xray/paths_ctlsock.go:34:20: S1002: should omit comparison to bool constant, can be simplified to `!eof` (gosimple)
	for eof := false; eof == false; line++ {
	                  ^
tests/reverse/xattr_test.go:19:2: S1008: should use 'return err2.Err != syscall.EOPNOTSUPP' instead of 'if err2.Err == syscall.EOPNOTSUPP { return false }; return true' (gosimple)
	if err2.Err == syscall.EOPNOTSUPP {
	^
internal/fusefrontend/node.go:459:45: S1002: should omit comparison to bool constant, can be simplified to `!nameFileAlreadyThere` (gosimple)
		if nametransform.IsLongContent(cName2) && nameFileAlreadyThere == false {
		                                          ^
tests/xattr/xattr_integration_test.go:221:2: S1008: should use 'return err2.Err != syscall.EOPNOTSUPP' instead of 'if err2.Err == syscall.EOPNOTSUPP { return false }; return true' (gosimple)
	if err2.Err == syscall.EOPNOTSUPP {
	^
tests/test_helpers/helpers.go:338:19: S1002: should omit comparison to bool constant, can be simplified to `open` (gosimple)
	if err != nil && open == true {
	                 ^
tests/matrix/concurrency_test.go:121:7: S1004: should use !bytes.Equal(buf, content) instead (gosimple)
			if bytes.Compare(buf, content) != 0 {
			   ^
2021-08-19 08:34:44 +02:00
..
configfile fido2: hide "FIDO2" in gocryptfs.conf if not used 2021-06-20 18:09:21 +02:00
contentenc Improve startup debug output 2021-06-21 11:32:04 +02:00
cryptocore Improve startup debug output 2021-06-21 11:32:04 +02:00
ctlsocksrv ctlsock: create exported ctlsock client library 2020-05-09 17:36:41 +02:00
ensurefds012 main: Run 'ensure fds' code early during the program startup. 2019-01-05 16:12:16 +01:00
exitcodes Add support for FIDO2 tokens 2020-09-12 18:06:54 +02:00
fido2 fido2: actually drop -v flag 2021-07-29 12:47:40 +02:00
fusefrontend golangci-lint: fix issues found by gosimple 2021-08-19 08:34:44 +02:00
fusefrontend_reverse Update dependencies 2021-08-18 17:30:01 +02:00
inomap inomap: update outdated wording in comments 2021-08-16 17:14:14 +02:00
nametransform nametransform: rename BadNameFlag to BadnameSuffix 2021-06-21 12:12:44 +02:00
openfiletable inomap: split into separate package 2020-04-13 14:54:04 +02:00
pathiv pathiv: fix test failure on Go 1.6 2017-05-31 08:21:36 +02:00
readpassword main: accept multiple -passfile options 2020-05-17 19:31:04 +02:00
serialize_reads serialize_reads: drop superflous "continue" 2019-09-08 21:19:44 +02:00
siv_aead siv_aead: create private key copy and implement wiping 2018-02-18 16:01:46 +01:00
speed -speed: note that XChaCha20 is not selectable 2021-05-18 09:53:23 +02:00
stupidgcm golangci-lint: fix issues found by gosimple 2021-08-19 08:34:44 +02:00
syscallcompat Fix issues found by ineffassign 2021-08-18 15:48:01 +02:00
tlog tlog: switch from golang.org/x/crypto/ssh/terminal to golang.org/x/term 2021-08-19 07:38:56 +02:00