hardcoresushi
/
libgocryptfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity
libgocryptfs/tests
History
Jakob Unterwurzacher cd7a686211 tests: fix data race in TestDirIVRace 
Ironically, the test for DirIV races had a data race itself
by writing to a bool without taking a lock.

Found by running "./test.bash -race":

WARNING: DATA RACE
Write at 0x00c00001dea5 by goroutine 22:
  github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func1()
      /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:39 +0x38
  github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace()
      /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:73 +0x65c
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Previous read at 0x00c00001dea5 by goroutine 23:
  github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func2()
      /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:51 +0x8b

Goroutine 22 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:916 +0x699
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1157 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1155 +0x523
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1072 +0x2eb
  github.com/rfjakob/gocryptfs/tests/defaults.TestMain()
      /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:21 +0xe1
  main.main()
      _testmain.go:76 +0x222

Goroutine 23 (running) created at:
  github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace()
      /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:43 +0x48d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163
==================
--- FAIL: TestDirIVRace (0.00s)
    testing.go:809: race detected during execution of test
FAIL
 		2019-03-03 14:09:33 +01:00
..
cli tests: teach ListFds() to check other processes 2019-01-01 20:05:38 +01:00
defaults tests: fix data race in TestDirIVRace 2019-03-03 14:09:33 +01:00
example_filesystems Assorted spelling fixes. 2018-12-27 15:19:55 +01:00
fsck fsck: handle sparse files efficiently, fix xfstests generic/285 2018-07-01 21:48:51 +02:00
hkdf_sanity tests: add hkdf_sanity tests with broken example filesystem 2017-03-18 16:48:58 +01:00
matrix tests: fix compile error in matrix_test.go 2019-02-17 17:25:41 +01:00
plaintextnames configfile: add LoadAndDecrypt wrapper 2018-09-08 12:40:29 +02:00
reverse Revert "syscallcompat: drop Faccessat AT_SYMLINK_NOFOLLOW helper" 2019-01-20 13:10:59 +01:00
stress_tests tests: parallel_cp.sh: automount fs 2019-02-17 16:02:30 +01:00
symlink_race tests: add symlink_race tool 2018-09-23 12:17:26 +02:00
test_helpers tests: check that we can delete directories with all permission 2019-01-20 14:32:59 +01:00
trezor configfile: add LoadAndDecrypt wrapper 2018-09-08 12:40:29 +02:00
xattr fusefrontend: Allow to set/remove xattr on directory without read permission. 2019-01-05 12:34:40 +01:00
canonical-benchmarks.bash benchmarks: add streaming read benchmark 2017-06-27 00:04:58 +02:00
dl-linux-tarball.bash macos: tests: use curl of wget is not available 2018-03-07 09:40:48 +01:00
fuse-unmount.bash Assorted spelling fixes. 2018-12-27 15:19:55 +01:00
len2elen.sh test: len2elen.sh: fix first line output 2019-02-17 16:06:05 +01:00
maxlen.bash maxlen.bash: result was 1 too high 2016-10-04 10:26:22 +02:00