From 42de305b7c3bc057f31e9a1cbb62c67e2f2b0c2c Mon Sep 17 00:00:00 2001 From: inthewaves <26474149+inthewaves@users.noreply.github.com> Date: Mon, 24 Aug 2020 21:58:59 -0700 Subject: [PATCH] move initial showSystemUi call to loadPdf The reasoning for calling showSystemUi() in the onCreate method before was to make the transitions for immersive mode more smooth. However, it's only needed when the PDF has actually loaded, i.e. when the immersive mode makes sense to use. Before, Snackbars were partially covered by the navigation UI due to the showSystemUi() setting the View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION flag. Moving it so that the function is only called when a PDF is loaded fixes this issue. --- .../java/org/grapheneos/pdfviewer/PdfViewer.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/grapheneos/pdfviewer/PdfViewer.java b/app/src/main/java/org/grapheneos/pdfviewer/PdfViewer.java index 22517fa..606a1da 100644 --- a/app/src/main/java/org/grapheneos/pdfviewer/PdfViewer.java +++ b/app/src/main/java/org/grapheneos/pdfviewer/PdfViewer.java @@ -29,15 +29,15 @@ import androidx.loader.content.Loader; import com.google.android.material.snackbar.Snackbar; +import org.grapheneos.pdfviewer.fragment.DocumentPropertiesFragment; +import org.grapheneos.pdfviewer.fragment.JumpToPageFragment; +import org.grapheneos.pdfviewer.loader.DocumentPropertiesLoader; + import java.io.IOException; import java.io.InputStream; import java.util.HashMap; import java.util.List; -import org.grapheneos.pdfviewer.fragment.DocumentPropertiesFragment; -import org.grapheneos.pdfviewer.fragment.JumpToPageFragment; -import org.grapheneos.pdfviewer.loader.DocumentPropertiesLoader; - public class PdfViewer extends AppCompatActivity implements LoaderManager.LoaderCallbacks> { public static final String TAG = "PdfViewer"; @@ -234,8 +234,6 @@ public class PdfViewer extends AppCompatActivity implements LoaderManager.Loader } }); - showSystemUi(); - GestureHelper.attach(PdfViewer.this, mWebView, new GestureHelper.GestureListener() { @Override @@ -338,6 +336,8 @@ public class PdfViewer extends AppCompatActivity implements LoaderManager.Loader snackbar.setText(R.string.io_error).show(); return; } + + showSystemUi(); mWebView.loadUrl("https://localhost/viewer.html"); }