From fd510a3c1975ed4be1f122090a00fa522de6238c Mon Sep 17 00:00:00 2001 From: Daniel Micay Date: Wed, 28 Dec 2022 12:08:22 -0500 Subject: [PATCH] avoid deprecated DialogFragment onActivityCreated --- .../fragment/JumpToPageFragment.java | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/app/grapheneos/pdfviewer/fragment/JumpToPageFragment.java b/app/src/main/java/app/grapheneos/pdfviewer/fragment/JumpToPageFragment.java index ce9f28d..95bee27 100644 --- a/app/src/main/java/app/grapheneos/pdfviewer/fragment/JumpToPageFragment.java +++ b/app/src/main/java/app/grapheneos/pdfviewer/fragment/JumpToPageFragment.java @@ -22,23 +22,19 @@ public class JumpToPageFragment extends DialogFragment { private NumberPicker mPicker; - @Override - public void onActivityCreated(Bundle savedInstanceState) { - super.onActivityCreated(savedInstanceState); - if (savedInstanceState != null) { - mPicker.setMinValue(savedInstanceState.getInt(STATE_PICKER_MIN)); - mPicker.setMaxValue(savedInstanceState.getInt(STATE_PICKER_MAX)); - mPicker.setValue(savedInstanceState.getInt(STATE_PICKER_CUR)); - } - } - @NonNull @Override public Dialog onCreateDialog(Bundle savedInstanceState) { mPicker = new NumberPicker(getActivity()); - mPicker.setMinValue(1); - mPicker.setMaxValue(((PdfViewer)requireActivity()).mNumPages); - mPicker.setValue(((PdfViewer)requireActivity()).mPage); + if (savedInstanceState != null) { + mPicker.setMinValue(savedInstanceState.getInt(STATE_PICKER_MIN)); + mPicker.setMaxValue(savedInstanceState.getInt(STATE_PICKER_MAX)); + mPicker.setValue(savedInstanceState.getInt(STATE_PICKER_CUR)); + } else { + mPicker.setMinValue(1); + mPicker.setMaxValue(((PdfViewer)requireActivity()).mNumPages); + mPicker.setValue(((PdfViewer)requireActivity()).mPage); + } final FrameLayout layout = new FrameLayout(getActivity()); layout.addView(mPicker, new FrameLayout.LayoutParams(