From ef17b184e0c9e394c1865b9df2a20525b3696595 Mon Sep 17 00:00:00 2001 From: Matthias Date: Tue, 22 Oct 2024 23:05:29 +0200 Subject: [PATCH] correct typos, adapt chmod of bash scripts Signed-off-by: Matthias --- README.md | 13 ++++++++----- batch_get_username.sh | 4 +++- get_sequences_of_username.py | 2 +- get_user.sh | 0 secrets_variables_example.sh | 4 +++- 5 files changed, 15 insertions(+), 8 deletions(-) mode change 100644 => 100755 batch_get_username.sh mode change 100644 => 100755 get_user.sh diff --git a/README.md b/README.md index 0b6bde9..f6a92a8 100644 --- a/README.md +++ b/README.md @@ -3,9 +3,9 @@ Simple code to download images in one or several mapillary sequences. The images ## How to use ### Setup env variables -copy the secret variables files to setup your maipllary dev token, and your panoramax OpenStreetMap token. +copy the secret variables files to setup your mapillary dev token, and your panoramax OpenStreetMap token. ```Shell -cp secrets_variables_examples.sh secrets_variables.sh +cp secrets_variables_example.sh secrets_variables.sh editor secrets_variables.sh ``` @@ -13,10 +13,13 @@ editor secrets_variables.sh To avoid to download everything at once, this is a 2 steps process: - 1/ We set a list of users for which we want to get the list of sequences to download, and get a bash script for each user. Change the list of users in the batch file `batch_get_username.sh`. - change the access token with your access token and the sequence ids with the ids of the sequences you want to download ```bash usernames=( "someone_having_nice_pictures" "someone_else" "oh_look_a_these_usernames" ) # use real accounts, it might work better ``` + then, execute: + ```bash + ./batch_get_username.sh + ``` This will give you a few files that the other scripts will use to generate a script to download all sequences of each user. One user, one bash script generated. @@ -25,7 +28,7 @@ To avoid to download everything at once, this is a 2 steps process: bash script_bash_get_sequences_for_user_SOMEONE.sh ``` **Or all of the generated batch scripts at once.** - + ```bash bash script_bash_get_sequences_for_user_* ``` @@ -101,7 +104,7 @@ python3 -m venv mly_venv source mly_venv/bin/activate python -m pip install -r requirements.txt ``` -Then you can run `python mapillary_download "MLY|xxxx|xxxxxxx" --sequence_ids xxxxxxxxxxx` +Then you can run `python mapillary_download.py "MLY|xxxx|xxxxxxx" --sequence_ids xxxxxxxxxxx` When you're done with the script, simply run `deactivate` to exit the virtual environnement. On windows you can create a virtual environnement too, or use the prebuilt `mapillary_download.exe` available on the release page. diff --git a/batch_get_username.sh b/batch_get_username.sh old mode 100644 new mode 100755 index da8cab1..e67e769 --- a/batch_get_username.sh +++ b/batch_get_username.sh @@ -28,6 +28,8 @@ echo "---------- utilisateur: $username" if [ ! -f "out_$username.json" ]; then bash find_user_id.sh $username + #FIXME: find_user_id.sh is not part of this repo. maybe get_user.sh? + #FIXME: also check if file is empty? fi # Vérifier si le fichier sequences_$username.txt existe if [ ! -f "sequences_$username.txt" ]; then @@ -41,4 +43,4 @@ echo "---------- utilisateur: $username" fi done -echo "---------- finished getting users ------------" \ No newline at end of file +echo "---------- finished getting users ------------" diff --git a/get_sequences_of_username.py b/get_sequences_of_username.py index 4184112..251445f 100644 --- a/get_sequences_of_username.py +++ b/get_sequences_of_username.py @@ -7,7 +7,7 @@ import argparse def parse_args(argv =None): parser = argparse.ArgumentParser() - parser.add_argument('--username', type=str, help='Username to get the sequences id of') + parser.add_argument('--username', type=str, help='Username to get the sequences id of', required=True) parser.add_argument('--dev_token', type=str, help='Your mapillary developer token') parser.add_argument('--max_sequence', type=str, help='Username to get the sequences id of') diff --git a/get_user.sh b/get_user.sh old mode 100644 new mode 100755 diff --git a/secrets_variables_example.sh b/secrets_variables_example.sh index 80d88d8..d3f9e23 100644 --- a/secrets_variables_example.sh +++ b/secrets_variables_example.sh @@ -1,5 +1,7 @@ # scripts common shared variables # this is to copy as a file named "secrets_variables.sh" which is ignored in this git repo - +# Mapillary: +# register an application at https://www.mapillary.com/dashboard/developers +# read permissions needed, all other fields can be random. copy the client token export MAPILLARY_DEV_TOKEN="MLY|blahblah_replace_it"