Correcting some bugs and enhance the selection and UI

src/critical.py

@@ -36,7 +36,7 @@ import logger                   # logger.py
 import globs                    # globs.py
 import github                   # github.py
 
-def crashCNIR(shutdown=True):
+def crashCNIR(shutdown=True, option="", isVoluntary=False):
     """
     very last solution
     """
@@ -47,13 +47,14 @@ def crashCNIR(shutdown=True):
         logfile = logger.logCur
         logfile.printerr("FATAL ERROR : see traceback below.\n{}".format(traceback.format_exc()))
 
-        showerror(lang.all[globs.CNIRlang]["CNIRevelator Fatal Eror"], lang.all[globs.CNIRlang]["CNIRevelator crashed because a fatal error occured. View log for more infos and please open an issue on Github"])
+        if not isVoluntary:
+            showerror(lang.all[globs.CNIRlang]["CNIRevelator Fatal Eror"], lang.all[globs.CNIRlang]["CNIRevelator crashed because a fatal error occured. View log for more infos and please open an issue on Github"] + "\n\n{}\n{}".format(option, traceback.format_exc()))
 
-        # Force new update
+            # Force new update
-        try:
+            try:
-            os.remove(globs.CNIRLastUpdate)
+                os.remove(globs.CNIRLastUpdate)
-        except:
+            except:
-            pass
+                pass
 
         res = askquestion(lang.all[globs.CNIRlang]["CNIRevelator Fatal Eror"], lang.all[globs.CNIRlang]["Would you like to report this bug ?"])
         if res == "yes":
@@ -66,7 +67,7 @@ def crashCNIR(shutdown=True):
                 logfile.printerr("Can't read the log file.")
 
             # send it
-            success = github.reportBug(traceback.format_exc(), data)
+            success = github.reportBug(traceback.format_exc(), data, isVoluntary)
 
             if not success:
                 logfile.printerr("Can't send to Github.")

src/downloader.py

@@ -81,10 +81,11 @@ class newcredentials:
             self.trying += 1
             
             try:
-                sessionAnswer = session.get('https://www.google.com')
+                sessionAnswer = session.get('http://www.google.com')
             except Exception as e:
                 logfile.printdbg('Network Error : ' + str(e))
-                sessionAnswer = ''
+                self.login = "nointernet"
+                return
                 
             logfile.printdbg("Session Answer : " + str(sessionAnswer))
             
@@ -94,11 +95,6 @@ class newcredentials:
                 self.valid = True
                 return
             
-            if str(sessionAnswer) != '<Response [407]>' and self.trying > 2: 
-            # because sometimes the proxy does not return an error (especially if we do not provide either credentials)
-                logfile.printerr('Network Error, or need a proxy !')
-                return
-            
             if self.trying > 4:
                 logfile.printerr('Invalid credentials : access denied, a maximum of 3 trials have been raised !')
                 return

src/github.py

@@ -60,7 +60,7 @@ class AESCipher(object):
     def _unpad(s):
         return s[:-ord(s[len(s) - 1:])]
 
-def reportBug(reason="",log=""):
+def reportBug(reason="",log="", isVoluntary=False):
 
     logfile = logger.logCur
 
@@ -70,11 +70,14 @@ def reportBug(reason="",log=""):
 
     session = credentials.sessionHandler
 
-    payload = {'title':"CNIRevelator Bug Report", 'body':"**An error has been reported by a CNIRevelator instance.**\n\n**Here is the full reason of this issue:**\n{}\n\n**The full log is here:** {}".format(reason, log), "assignees":["neox95"], "labels":["bug", "AUTO"]}
+    if not isVoluntary:
+        payload = {'title':"CNIRevelator Bug Report", 'body':"**An error has been reported by a CNIRevelator instance.**\n\n**Here is the full reason of this issue:**\n{}\n\n**The full log is here:** {}".format(reason, log), "assignees":["neox95"], "labels":["bug", "AUTO"]}
+    else:
+        payload = {'title':"CNIRevelator Bug Report", 'body':"**A voluntary bug report has been reported by a CNIRevelator user.**\n\n**Possible reason:**\n{}\n\n**The full log is here:** {}".format(reason, log), "assignees":["neox95"], "labels":["bug", "AUTO"]}
 
     handler = session.post('https://api.github.com/repos/neox95/cnirevelator/issues', headers={'Authorization': 'token %s' % decryptToken(globs.CNIRGitToken)}, data=json.dumps(payload))
 
-    logfile.printdbg(handler.reason)
+    logfile.printdbg("Issue is " + handler.reason)
 
     if handler.reason == "Created":
         return True

src/globs.py

@@ -26,7 +26,7 @@
 import os
 
 # CNIRevelator version
-verType             = "beta release"
+verType             = "stable release"
 version             = [3, 1, 5]
 verstring_full      = "{}.{}.{} {}".format(version[0], version[1], version[2], verType)
 verstring           = "{}.{}".format(version[0], version[1])

src/ihm.py

@@ -30,7 +30,6 @@ from tkinter import filedialog
 from tkinter import ttk
 import PIL.Image, PIL.ImageTk
 import traceback
-import webbrowser
 import cv2
 
 import critical             # critical.py

src/lang.py

@@ -141,7 +141,7 @@ french = \
                                         "Coller :\t\t\t\tCtrl-V \n"
                                         "Forcer une nouvelle détection du document :\tEchap\n",
 
-"CHANGELOG"                         :   "Version 3.1.5 \nMise-à-jour mineure avec les progressions suivantes :\n- Correction d'un bug affectant le signalement de bug\n- Améliorations de l'affichage de la conformité des informations\n\n" + \
+"CHANGELOG"                         :   "Version 3.1.5 \nMise-à-jour mineure avec les progressions suivantes :\n- Correction d'un bug affectant le signalement de bug\n- Améliorations de l'affichage de la conformité des informations\n- Ajout d'un nouveau système de selection plus simple et fiable'\n\n" + \
 "Version 3.1.4 \nMise-à-jour mineure avec les progressions suivantes :\n- Correction d'un bug affectant la rotation de documents dans l'afficheur d'images\n- Ajout d'une période de mise-à-jour afin d'éviter de rechercher les mises-à-jour tous les jours\n\n" + \
 "Version 3.1.3 \nMise-à-jour mineure avec les progressions suivantes :\n- Correction d'un bug de la détection automatique de documents\n- Ajout d'une fonctionnalité de rapport d'erreur\n\n" + \
 "Version 3.1.2 \nMise-à-jour mineure avec les progressions suivantes :\n- Montée de version de Tesseract OCR : 5.0\n- Correction de noms des documents\n- Résolution d'un problème avec le système de mise-à-jour\n- Amélioration des effets sur images\n\n" + \
@@ -208,6 +208,9 @@ french = \
 "does not contain any non unicode "
 "character such as accent and "
 "foreign characters."               :   "Une erreur critique s'est produite dans le gestionnaire de traitement d'images OpenCV utilisé par CNIRevelator. Veuillez vous assurer que le nom de fichier ne contient pas de caractères non unicode tels que des accents et des caractères étrangers.",
+"No Internet Error. No effective "
+"update !"                          :   "Aucune connectivité. Pas de mise-à-jour !",
+"Project Webpage"                   :   "Site internet du projet",
 
 "LANDCODE2"                         :   {
                                             'AW': 'Aruba',
@@ -810,6 +813,8 @@ english = \
 "the OpenCV image processing "
 "manager used by CNIRevelator, the "
 "application will reset itself"     :   "A critical error has occurred in the OpenCV image processing manager used by CNIRevelator, the application will reset itself",
+"No Internet Error. No effective "
+"update !"                          :   "No Internet Error. No effective update !",
 
 "ABOUT"                             :   'Software Version: CNIRevelator' + globs.verstring_full + '\n\n'
                                         "Copyright © 2018-2019 Adrien Bourmault (neox95)" + "\n\n"
@@ -848,7 +853,7 @@ english = \
                                         "Paste:\t\t\t\tCtrl-V\n"
                                         "Force a new document detection:\tEchap\n",
 
-"CHANGELOG"                         :   "Version 3.1.5 \nMinor update with the following progressions:\n- Correction of a bug affecting bug reporting\n - Enhancements on information compliance display\n\n" + \
+"CHANGELOG"                         :   "Version 3.1.5 \nMinor update with the following progressions:\n- Correction of a bug affecting bug reporting\n - Enhancements on information compliance display\n- Added new selection system to be more userfriendly\n\n" + \
 "Version 3.1.4 \nMinor update with the following progressions:\n- Correction of a bug affecting rotation of document in image viewer\n- Added a new update period to prevent updating everyday\n\n" + \
 "Version 3.1.3 \nMinor update with the following progressions:\n- Correction of a bug affecting automated document detection\n- Added bug reporting functionnality\n\n" + \
 "Version 3.1.2 \nMinor update with the following progressions: \n- Tesseract OCR version upgrade : 5.0\n- Correction of document names\n- Fixed a problem with the update system\n- Some enhancements about effects on images\n\n" + \
@@ -915,6 +920,7 @@ english = \
 "does not contain any non unicode "
 "character such as accent and "
 "foreign characters."               :   "A critical error has occurred in the OpenCV image processing manager used by CNIRevelator. Please be sure that the filename does not contain any non unicode character such as accent and foreign characters.",
+"Project Webpage"                   :   "Project website",
 
 "LANDCODE2"                         :   {
                                             "AW": "Aruba",

src/main.py

@@ -38,9 +38,9 @@ import re
 import cv2
 import PIL.Image, PIL.ImageTk
 import os, shutil
-import webbrowser
 import sys, os
 import numpy
+import webbrowser
 
 import critical                 # critical.py
 import ihm                      # ihm.py
@@ -71,6 +71,7 @@ class mainWindow(Tk):
         self.Tags = []
         self.compliance = True
         self.corners = []
+        self.indicators = []
         self.validatedtext = ""
 
         # The icon
@@ -352,6 +353,7 @@ class mainWindow(Tk):
         menu3.add_command(label=lang.all[globs.CNIRlang]["Keyboard commands"], command=(self.helpbox))
         menu3.add_command(label=lang.all[globs.CNIRlang]["Report a bug"], command=(self.openIssuePage))
         menu3.add_separator()
+        menu3.add_command(label=lang.all[globs.CNIRlang]["Project Webpage"], command=(self.openProjectPage))
         menu3.add_command(label=lang.all[globs.CNIRlang]["About CNIRevelator"], command=(self.infobox))
         menubar.add_cascade(label=lang.all[globs.CNIRlang]["Help"], menu=menu3)
         menubar.add_command(label="<|>", command=(self.panelResize))
@@ -410,11 +412,19 @@ class mainWindow(Tk):
             
             self.corners.append([canvas.canvasx(event.x), canvas.canvasy(event.y)])
             if len(self.corners) == 2:
-                self.select = self.imageViewer.ZONE.create_rectangle(self.corners[0][0], self.corners[0][1], self.corners[1][0], self.corners[1][1], outline ='cyan', width = 2)
+                self.select = self.imageViewer.ZONE.create_rectangle(self.corners[0][0], self.corners[0][1], self.corners[1][0], self.corners[1][1], outline ='red', width = 2)
                 #print("Get rectangle : [{}, {}], for [{}, {}]".format(self.corners[0][0], self.corners[0][1], self.corners[1][0], self.corners[1][1]))
+            
+            # Reinit
             if len(self.corners) > 2:
                 self.corners = []
-                self.imageViewer.ZONE.delete(self.select)
+                self.imageViewer.ZONE.delete(self.select)                
+                for k in self.indicators:
+                    self.imageViewer.ZONE.delete(k)
+            
+            # Draw indicator
+            else:
+                 self.indicators.append(self.imageViewer.ZONE.create_oval(canvas.canvasx(event.x)-4, canvas.canvasy(event.y)-4,canvas.canvasx(event.x)+4, canvas.canvasy(event.y)+4, fill='red', outline='red', width = 2))
 
     def goOCRDetection(self):
         """
@@ -448,10 +458,13 @@ class mainWindow(Tk):
             cv_img = cv2.resize(cv_img, dim, interpolation = cv2.INTER_AREA)
 
             # Crop
-            x0 = int(self.corners[0][0])
+            
-            y0 = int(self.corners[0][1])
+            coords = self.imageViewer.ZONE.coords(self.select)
-            x1 = int(self.corners[1][0])
+            
-            y1 = int(self.corners[1][1])
+            x0 = int(coords[0])
+            y0 = int(coords[1])
+            x1 = int(coords[2])
+            y1 = int(coords[3])
             crop_img = cv_img[y0:y1, x0:x1]
     
             # Get the text by OCR
@@ -724,7 +737,7 @@ class mainWindow(Tk):
         #print(docInfos)
         # display the infos
         for key in [ e for e in docInfos ]:
-            print(key)
+            #printkey)
             if key in ["CODE", "CTRL", "CTRLF", "FACULT", "NOINT"]:
                 continue
             if not docInfos[key][1] == False:
@@ -842,7 +855,7 @@ class mainWindow(Tk):
             cv_img = cv2.cvtColor(cv_img, cv2.COLOR_BGR2RGB)
         except:
             logfile.printerr("Error with : {} in {} with total of {} pages".format(cv2.imreadmulti(self.imageViewer.imagePath), self.imageViewer.imagePath, total))
-            showerror(lang.all[globs.CNIRlang]["OpenCV error (image processing)"], lang.all[globs.CNIRlang]["A critical error has occurred in the OpenCV image processing manager used by CNIRevelator. Please be sure that the filename does not contain any non unicode character such as accent and foreign characters."] + "\n\n" + self.imageViewer.imagePath)
+            critical.crashCNIR(False, "OpenCV openScanFile() error")
         
         try:
             # Get the image dimensions (OpenCV stores image data as NumPy ndarray)
@@ -855,6 +868,10 @@ class mainWindow(Tk):
             # Get the image dimensions (OpenCV stores image data as NumPy ndarray)
             height, width  = cv_img.shape
             
+            
+        # Update shape
+        self.imageViewer.height, self.imageViewer.width  = cv_img.shape[:2]
+                
         # Use PIL (Pillow) to convert the NumPy ndarray to a PhotoImage
         photo = PIL.ImageTk.PhotoImage(image = PIL.Image.fromarray(cv_img))
         self.DisplayUpdate(photo)    
@@ -865,7 +882,7 @@ class mainWindow(Tk):
             self.resizeScan()
 
     def zoomOutScan50(self, quantity = 50):
-        if self.imageViewer.image:
+        if self.imageViewer.image and int(self.imageViewer.width * (self.imageViewer.imgZoom - quantity + 100) / 100) > 100:
             self.imageViewer.imgZoom -= quantity
             self.resizeScan()
 
@@ -875,7 +892,7 @@ class mainWindow(Tk):
             self.resizeScan()
 
     def zoomOutScan20(self, quantity = 20):
-        if self.imageViewer.image:
+        if self.imageViewer.image and int(self.imageViewer.width * (self.imageViewer.imgZoom - quantity + 100) / 100) > 100:
             self.imageViewer.imgZoom -= quantity
             self.resizeScan()
 
@@ -885,7 +902,7 @@ class mainWindow(Tk):
             self.resizeScan()
 
     def zoomOutScan(self, quantity = 1):
-        if self.imageViewer.image:
+        if self.imageViewer.image and int(self.imageViewer.width * (self.imageViewer.imgZoom - quantity + 100) / 100) > 100:
             self.imageViewer.imgZoom -= quantity
             self.resizeScan()
 
@@ -997,6 +1014,9 @@ class mainWindow(Tk):
                 dim = (int(width * (self.imageViewer.imgZoom + 100) / 100), int(height * (self.imageViewer.imgZoom + 100) / 100))
                 cv_img = cv2.resize(cv_img, dim, interpolation = cv2.INTER_AREA)
                 
+                # Update shape
+                self.imageViewer.height, self.imageViewer.width  = cv_img.shape[:2]
+                
                 # Use PIL (Pillow) to convert the NumPy ndarray to a PhotoImage
                 photo = PIL.ImageTk.PhotoImage(image = PIL.Image.fromarray(cv_img))
                 self.DisplayUpdate( photo)
@@ -1019,7 +1039,7 @@ class mainWindow(Tk):
                     self.DisplayUpdate(photo)
                 except Exception as e:
                     logfile.printerr("Critical error with opencv : ".format(e))
-                    showerror(lang.all[globs.CNIRlang]["OpenCV error (image processing)"], lang.all[globs.CNIRlang]["A critical error has occurred in the OpenCV image processing manager used by CNIRevelator, the application will reset itself"])
+                    critical.crashCNIR(False, "OpenCV resizeScan() error")
                     self.initialize()
 
     ## IHM and user interface related functions
@@ -1058,9 +1078,15 @@ class mainWindow(Tk):
         
     def openIssuePage(self):
         """
-        Opens the Github Issue Repository page
+        Sends a bug report
         """
-        webbrowser.open_new("https://github.com/neox95/CNIRevelator/issues")
+        critical.crashCNIR(shutdown=False, option="Voluntary Bug Report", isVoluntary=True)
+        
+    def openProjectPage(self):
+        """
+        Opens the Project Repository webpage
+        """
+        webbrowser.open_new("https://github.com/neox95/CNIRevelator")
         
     def showChangeLog(self):
         changelogWin = ihm.ChangelogDialog(self, ('{} : CNIRevelator {}\n\n{}'.format(lang.all[globs.CNIRlang]["Program version"], globs.verstring_full, lang.all[globs.CNIRlang]["CHANGELOG"])))

src/pytesseract.py

@@ -24,7 +24,7 @@
 * along with CNIRevelator. If not, see <https:*www.gnu.org/licenses/>.         *
 ********************************************************************************
 """
-                            
+import logger           # logger.pu
         
 try:
     import Image
@@ -248,7 +248,7 @@ def image_to_string(image, lang=None, config='', nice=0, boxes=False, output_typ
     Returns the result of a Tesseract OCR run on the provided image to string
     """
     if boxes:
-        print("\nWarning: Argument 'boxes' is deprecated and will be removed in future versions. Use function image_to_boxes instead.\n")
+        logfile.printdbg("\nWarning: Argument 'boxes' is deprecated and will be removed in future versions. Use function image_to_boxes instead.\n")
         return image_to_boxes(image, lang, config, nice, output_type)
     else:
         args = [
@@ -317,7 +317,7 @@ def main():
             sys.stderr.write('Usage: python pytesseract.py [-l lang] input_file\n')
             exit(2)
     try:
-        print(image_to_string((Image.open(filename)), lang=lang))
+        logfile.printdbg(image_to_string((Image.open(filename)), lang=lang))
     except IOError:
         sys.stderr.write('ERROR: Could not open file "%s"\n' % filename)
         exit(1)

src/updater.py

@@ -378,8 +378,12 @@ def umain():
     credentials = downloader.newcredentials()
     
     if not credentials.valid:
-        logfile.printerr("Credentials Error. No effective update !")
+        if credentials.login == "nointernet":
-        launcherWindow.printmsg(lang.all[globs.CNIRlang]["Credentials Error. No effective update !"])
+            logfile.printerr("No Internet Error. No effective update !")
+            launcherWindow.printmsg(lang.all[globs.CNIRlang]["No Internet Error. No effective update !"])
+        else:
+            logfile.printerr("Credentials Error. No effective update !")
+            launcherWindow.printmsg(lang.all[globs.CNIRlang]["Credentials Error. No effective update !"])
         time.sleep(2)
         launcherWindow.exit()
         return 0