enrich display config of a poll

src/Controller/api/PollController.php

@@ -101,19 +101,31 @@ class PollController extends EmailsController {
 		}
 
 		$comments = $poll->getComments();
-		$pass     = $poll->getPassword();
+		$stacks   = $poll->getStacksOfVotes();
+
+		$displayedComments = [];
+		foreach ( $comments as $comment ) {
+			$displayedComments[] = $comment->display();
+		}
+		$displayedStackOfVotes = [];
+		foreach ( $stacks as $stack ) {
+			$displayedStackOfVotes[] = $stack->display();
+		}
+		$displayedChoices = [];
+		foreach ( $poll->getChoices() as $choice
+		) {
+			$displayedChoices[] = $choice->display();
+		}
+		$pass = $poll->getPassword();
 
 		$returnedPoll = [
-			'message'            => 'your poll config for ' . $poll->getTitle(),
+			'message' => 'your poll config for ' . $poll->getTitle(),
-			'password_protected' => $pass ? 'yes' : 'no',
+
-			// TODO do not render sub objects of owner, it returns too many things
+			'poll'           => $poll->display(),
-			'poll'               => $poll,
+			// TODO do not render sub objects of owner, it returns too many thing
-			'stacks_count'       => count( $poll->getStacksOfVotes() ),
+			'stacks'         => $displayedStackOfVotes,
-			'stacks'             => $poll->getStacksOfVotes(),
+			'choices'        => $displayedChoices,
-			'choices_count'      => $poll->computeAnswers(),
+			'comments'       => $displayedComments,
-			'choices'            => $poll->getChoices(),
-			'comments'           => $comments,
-			'comments_count'     => count( $comments ),
 		];
 
 		/**
@@ -129,8 +141,8 @@ class PollController extends EmailsController {
 		} else {
 			// free access to poll
 //			return $this->returnPollData( $poll, $serializer );
-//			return $this->json($returnedPoll);
+			return $this->json( $returnedPoll );
-			return $this->json($poll);
+//			return $this->json($poll);
 		}
 
 	}

src/Entity/Choice.php

@@ -66,7 +66,7 @@
 			return [
 					'id'   => $this->getId(),
 					'date' => $this->getDateTime(),
-					'text' => $this->getName(),
+					'name' => $this->getName(),
 					'url'  => $this->getUrl(),
 			];
 		}

src/Entity/Poll.php

@@ -232,7 +232,6 @@ class Poll {
 				}
 			}
 		}
-
 		return [
 			'counts'   => $computedArray,
 			'maxScore' => $maxScore,
@@ -241,7 +240,8 @@ class Poll {
 
 	public function display() {
 		return [
-			'poll'    => $this,
+			'config'    => $this,
+			'password_protected' => $this->getPassword() ? 'yes' : 'no',
 			'answers' => $this->computeAnswers(),
 		];
 	}

src/Entity/StackOfVotes.php

@@ -46,7 +46,7 @@ class StackOfVotes {
 	public function display() {
 		$tab = [
 			'id'             => $this->getId(),
-			'modifier_token' => $this->getOwner()->getModifierToken(),
+//			'modifier_token' => $this->getOwner()->getModifierToken(),
 			'pseudo'         => '',
 			'creation_date'  => '',
 			'votes'          => [],
@@ -55,13 +55,14 @@ class StackOfVotes {
 		foreach ( $this->getPoll()->getChoices() as $choice ) {
 			$tab[ 'votes' ][ $choice->getId() ] = [
 				'choice_id' => $choice->getId(),
+				'name' => $choice->getName(),
 			];
 		}
 
 		foreach ( $this->getVotes() as $vote ) {
-			$tab[ 'votes' ][ $vote->getChoice()->getId() ]               = $vote->display();
+//			$tab[ 'votes' ][ $vote->getChoice()->getId() ]               = $vote->display();
 			$tab[ 'votes' ][ $vote->getChoice()->getId() ][ 'stack_id' ] = $this->getId();
-			$tab[ 'pseudo' ]                                             = $this->getOwner()->getPseudo();
+			$tab[ 'pseudo' ]                                             = $this->getPseudo();
 			$tab[ 'creation_date' ]                                      = $vote->getCreationDate();
 		}