From ad9876633baf4f46830177929f82ac9a39a1d10b Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 22:42:49 +0100 Subject: [PATCH 1/8] angular upgrade: update short-unique-id package --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index e2dcc879..6cb4246a 100644 --- a/package.json +++ b/package.json @@ -73,7 +73,7 @@ "quill": "^1.3.7", "rxjs": "^6.5.5", "rxjs-compat": "^6.5.5", - "short-unique-id": "^3.0.3", + "short-unique-id": "^4.4.4", "stream": "^0.0.2", "tslib": "^2.0.0", "zone.js": "~0.11.4" diff --git a/yarn.lock b/yarn.lock index 424445e0..55c7cee4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11157,10 +11157,10 @@ shellwords@^0.1.1: resolved "https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b" integrity sha512-vFwSUfQvqybiICwZY5+DAWIPLKsWO31Q91JSKl3UYv+K5c2QRPzn0qzec6QPu1Qc9eHYItiP3NdJqNVqetYAww== -short-unique-id@^3.0.3: - version "3.2.3" - resolved "https://registry.yarnpkg.com/short-unique-id/-/short-unique-id-3.2.3.tgz#c35c8230d4ece9c27a14c41d2ca24730344c6e01" - integrity sha512-DaUTmZe2PP34AQ2DmBOjo0W41Br/74EbKmEosfipbMJdJf2MCdzgJBOXn+PRe/ERFnr9uRKnUa6Kb5X+VC3bCQ== +short-unique-id@^4.4.4: + version "4.4.4" + resolved "https://registry.yarnpkg.com/short-unique-id/-/short-unique-id-4.4.4.tgz#a45df68303bbd2dbb5785ed7708e891809c9cb7a" + integrity sha512-oLF1NCmtbiTWl2SqdXZQbo5KM1b7axdp0RgQLq8qCBBLoq+o3A5wmLrNM6bZIh54/a8BJ3l69kTXuxwZ+XCYuw== side-channel@^1.0.4: version "1.0.4" From ea09c4e854289cbefd19005d2644e4626595f64f Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 22:57:32 +0100 Subject: [PATCH 2/8] angular upgrade: migrate ng material component --- src/app/core/services/modal.service.ts | 5 +---- src/app/core/services/toast.service.ts | 5 +---- .../form/date/list/day/day-list.component.ts | 2 +- .../poll-results-compact.component.ts | 2 +- .../choice-details/choice-details.component.ts | 5 +---- .../components/settings/settings.component.ts | 2 +- src/app/shared/shared.module.ts | 14 +++++++------- src/styles.scss | 12 +++++++++++- src/styles/partials/_forms.scss | 4 +++- src/theme-contrast.scss | 2 ++ src/theme-dark.scss | 2 ++ src/theme-light.scss | 2 ++ 12 files changed, 33 insertions(+), 24 deletions(-) diff --git a/src/app/core/services/modal.service.ts b/src/app/core/services/modal.service.ts index b03c730d..215b0af2 100644 --- a/src/app/core/services/modal.service.ts +++ b/src/app/core/services/modal.service.ts @@ -1,9 +1,6 @@ import { ComponentType } from '@angular/cdk/portal'; import { Injectable, TemplateRef } from '@angular/core'; -import { - MatLegacyDialog as MatDialog, - MatLegacyDialogConfig as MatDialogConfig, -} from '@angular/material/legacy-dialog'; +import { MatDialog, MatDialogConfig } from '@angular/material/dialog'; @Injectable({ providedIn: 'root', diff --git a/src/app/core/services/toast.service.ts b/src/app/core/services/toast.service.ts index 103b11f3..c0680d49 100644 --- a/src/app/core/services/toast.service.ts +++ b/src/app/core/services/toast.service.ts @@ -1,8 +1,5 @@ import { Injectable } from '@angular/core'; -import { - MatLegacySnackBar as MatSnackBar, - MatLegacySnackBarConfig as MatSnackBarConfig, -} from '@angular/material/legacy-snack-bar'; +import { MatSnackBar, MatSnackBarConfig } from '@angular/material/snack-bar'; @Injectable({ providedIn: 'root', diff --git a/src/app/features/administration/form/date/list/day/day-list.component.ts b/src/app/features/administration/form/date/list/day/day-list.component.ts index 54f19966..e1f0cd2a 100644 --- a/src/app/features/administration/form/date/list/day/day-list.component.ts +++ b/src/app/features/administration/form/date/list/day/day-list.component.ts @@ -4,7 +4,7 @@ import { DOCUMENT } from '@angular/common'; import { UntypedFormGroup } from '@angular/forms'; import { ToastService } from '../../../../../../core/services/toast.service'; import { StorageService } from '../../../../../../core/services/storage.service'; -import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog'; +import { MatDialog } from '@angular/material/dialog'; import { DateChoice } from '../../../../../../core/models/dateChoice.model'; import { PollService } from '../../../../../../core/services/poll.service'; import { DateUtilitiesService } from '../../../../../../core/services/date.utilities.service'; diff --git a/src/app/features/consultation/poll-results-compact/poll-results-compact.component.ts b/src/app/features/consultation/poll-results-compact/poll-results-compact.component.ts index 4a32f9a4..366d421d 100644 --- a/src/app/features/consultation/poll-results-compact/poll-results-compact.component.ts +++ b/src/app/features/consultation/poll-results-compact/poll-results-compact.component.ts @@ -1,5 +1,5 @@ import { Component, Input, OnInit } from '@angular/core'; -import { MatLegacyDialogConfig as MatDialogConfig } from '@angular/material/legacy-dialog'; +import { MatDialogConfig } from '@angular/material/dialog'; import { Answer } from '../../../core/enums/answer.enum'; import { Choice } from '../../../core/models/choice.model'; diff --git a/src/app/shared/components/choice-details/choice-details.component.ts b/src/app/shared/components/choice-details/choice-details.component.ts index 1e934358..86692bd2 100644 --- a/src/app/shared/components/choice-details/choice-details.component.ts +++ b/src/app/shared/components/choice-details/choice-details.component.ts @@ -1,8 +1,5 @@ import { Component, Inject, OnInit } from '@angular/core'; -import { - MAT_LEGACY_DIALOG_DATA as MAT_DIALOG_DATA, - MatLegacyDialogRef as MatDialogRef, -} from '@angular/material/legacy-dialog'; +import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog'; import { Answer } from '../../../core/enums/answer.enum'; import { Choice } from '../../../core/models/choice.model'; diff --git a/src/app/shared/components/settings/settings.component.ts b/src/app/shared/components/settings/settings.component.ts index 1511fbbd..e52272dd 100644 --- a/src/app/shared/components/settings/settings.component.ts +++ b/src/app/shared/components/settings/settings.component.ts @@ -1,5 +1,5 @@ import { Component, OnInit } from '@angular/core'; -import { MatLegacyDialogRef as MatDialogRef } from '@angular/material/legacy-dialog'; +import { MatDialogRef } from '@angular/material/dialog'; import { Subscription } from 'rxjs'; import { Owner } from '../../../core/models/owner.model'; diff --git a/src/app/shared/shared.module.ts b/src/app/shared/shared.module.ts index e0feb301..d2556e48 100644 --- a/src/app/shared/shared.module.ts +++ b/src/app/shared/shared.module.ts @@ -2,15 +2,15 @@ import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; import { FormsModule } from '@angular/forms'; import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'; -import { MatLegacyCheckboxModule as MatCheckboxModule } from '@angular/material/legacy-checkbox'; +import { MatCheckboxModule } from '@angular/material/checkbox'; import { MatDatepickerModule } from '@angular/material/datepicker'; -import { MatLegacyDialogModule as MatDialogModule } from '@angular/material/legacy-dialog'; -import { MatLegacyFormFieldModule as MatFormFieldModule } from '@angular/material/legacy-form-field'; -import { MatLegacyInputModule as MatInputModule } from '@angular/material/legacy-input'; -import { MatLegacyProgressSpinnerModule as MatProgressSpinnerModule } from '@angular/material/legacy-progress-spinner'; +import { MatDialogModule } from '@angular/material/dialog'; +import { MatFormFieldModule } from '@angular/material/form-field'; +import { MatInputModule } from '@angular/material/input'; +import { MatProgressSpinnerModule } from '@angular/material/progress-spinner'; import { MatSidenavModule } from '@angular/material/sidenav'; -import { MatLegacySlideToggleModule as MatSlideToggleModule } from '@angular/material/legacy-slide-toggle'; -import { MatLegacySnackBarModule as MatSnackBarModule } from '@angular/material/legacy-snack-bar'; +import { MatSlideToggleModule } from '@angular/material/slide-toggle'; +import { MatSnackBarModule } from '@angular/material/snack-bar'; import { MatStepperModule } from '@angular/material/stepper'; import { TranslateModule } from '@ngx-translate/core'; import { NgChartsModule } from 'ng2-charts'; diff --git a/src/styles.scss b/src/styles.scss index 7aef9c4d..aa5cb630 100644 --- a/src/styles.scss +++ b/src/styles.scss @@ -13,9 +13,13 @@ // If you specify typography styles for the components you use elsewhere, you should delete this line. // If you don't need the default component typographies but still want the hierarchy styles, // you can delete this line and instead use: -// `@include mat.legacy-typography-hierarchy(mat.define-legacy-typography-config());` +// `@include mat.legacy-typography-hierarchy(mat.define-typography-config());` +/* TODO(mdc-migration): Remove all-legacy-component-typographies once all legacy components are migrated*/ @include mat.all-legacy-component-typographies(); +@include mat.all-component-typographies(); +/* TODO(mdc-migration): Remove legacy-core once all legacy components are migrated*/ @include mat.legacy-core(); +@include mat.core(); // import your custom themes @import 'theme-light.scss'; @@ -23,13 +27,19 @@ @import 'theme-contrast.scss'; .theme-light { + /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-light); + @include mat.all-component-themes($theme-light); } .theme-dark { + /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-dark); + @include mat.all-component-themes($theme-dark); } .theme-contrast { + /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-contrast); + @include mat.all-component-themes($theme-contrast); } /* diff --git a/src/styles/partials/_forms.scss b/src/styles/partials/_forms.scss index 6cdc94f0..a662eb98 100644 --- a/src/styles/partials/_forms.scss +++ b/src/styles/partials/_forms.scss @@ -70,6 +70,7 @@ textarea { } // radio input structure +/* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ .mat-checkbox-label, .mat-checkbox-layout .mat-checkbox-label { max-width: 90vw; @@ -190,12 +191,13 @@ textarea { -moz-border-radius-bottomright: 1em; } -.mat-error { +.mat-mdc-form-field-error { display: block; background: $warning; padding: 1em; } +/* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ mat-checkbox { display: block; } diff --git a/src/theme-contrast.scss b/src/theme-contrast.scss index d3fdde9d..fe40ed27 100644 --- a/src/theme-contrast.scss +++ b/src/theme-contrast.scss @@ -14,4 +14,6 @@ $theme-contrast: mat.define-light-theme($theme-contrast-primary, $theme-contrast // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. +/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-contrast); +@include mat.all-component-themes($theme-contrast); diff --git a/src/theme-dark.scss b/src/theme-dark.scss index 958bd587..402feb5a 100644 --- a/src/theme-dark.scss +++ b/src/theme-dark.scss @@ -14,4 +14,6 @@ $theme-dark: mat.define-dark-theme($theme-dark-primary, $theme-dark-accent, $the // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. +/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-dark); +@include mat.all-component-themes($theme-dark); diff --git a/src/theme-light.scss b/src/theme-light.scss index b6987c25..3ab7cfd0 100644 --- a/src/theme-light.scss +++ b/src/theme-light.scss @@ -14,4 +14,6 @@ $theme-light: mat.define-light-theme($theme-light-primary, $theme-light-accent, // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. +/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ @include mat.all-legacy-component-themes($theme-light); +@include mat.all-component-themes($theme-light); From 95bbd2a48af8a2bbeec54e9d46b7c5f731dca293 Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 23:16:44 +0100 Subject: [PATCH 3/8] angular upgrade: migrate ng material style --- src/app/shared/shared.module.ts | 2 +- src/styles.scss | 18 ------------------ src/styles/partials/_forms.scss | 14 +++++++------- src/theme-contrast.scss | 2 -- src/theme-dark.scss | 2 -- src/theme-light.scss | 2 -- 6 files changed, 8 insertions(+), 32 deletions(-) diff --git a/src/app/shared/shared.module.ts b/src/app/shared/shared.module.ts index d2556e48..a74ae2c2 100644 --- a/src/app/shared/shared.module.ts +++ b/src/app/shared/shared.module.ts @@ -1,7 +1,7 @@ import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; import { FormsModule } from '@angular/forms'; -import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'; +import { MatButtonModule } from '@angular/material/button'; import { MatCheckboxModule } from '@angular/material/checkbox'; import { MatDatepickerModule } from '@angular/material/datepicker'; import { MatDialogModule } from '@angular/material/dialog'; diff --git a/src/styles.scss b/src/styles.scss index aa5cb630..66b0be18 100644 --- a/src/styles.scss +++ b/src/styles.scss @@ -6,19 +6,7 @@ // Include the common styles for Angular Material. We include this here so that you only // have to load a single css file for Angular Material in your app. // Be sure that you only ever include this mixin once! -// TODO(v15): As of v15 mat.legacy-core no longer includes default typography styles. -// The following line adds: -// 1. Default typography styles for all components -// 2. Styles for typography hierarchy classes (e.g. .mat-headline-1) -// If you specify typography styles for the components you use elsewhere, you should delete this line. -// If you don't need the default component typographies but still want the hierarchy styles, -// you can delete this line and instead use: -// `@include mat.legacy-typography-hierarchy(mat.define-typography-config());` -/* TODO(mdc-migration): Remove all-legacy-component-typographies once all legacy components are migrated*/ -@include mat.all-legacy-component-typographies(); @include mat.all-component-typographies(); -/* TODO(mdc-migration): Remove legacy-core once all legacy components are migrated*/ -@include mat.legacy-core(); @include mat.core(); // import your custom themes @@ -27,18 +15,12 @@ @import 'theme-contrast.scss'; .theme-light { - /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ - @include mat.all-legacy-component-themes($theme-light); @include mat.all-component-themes($theme-light); } .theme-dark { - /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ - @include mat.all-legacy-component-themes($theme-dark); @include mat.all-component-themes($theme-dark); } .theme-contrast { - /* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ - @include mat.all-legacy-component-themes($theme-contrast); @include mat.all-component-themes($theme-contrast); } diff --git a/src/styles/partials/_forms.scss b/src/styles/partials/_forms.scss index a662eb98..a3431bfe 100644 --- a/src/styles/partials/_forms.scss +++ b/src/styles/partials/_forms.scss @@ -70,13 +70,13 @@ textarea { } // radio input structure -/* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ -.mat-checkbox-label, -.mat-checkbox-layout .mat-checkbox-label { - max-width: 90vw; - overflow-x: auto; - @extend .clickable; -} +// /* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ +// .mat-checkbox-label, +// .mat-checkbox-layout .mat-checkbox-label { +// max-width: 90vw; +// overflow-x: auto; +// @extend .clickable; +// } button, .button { font-family: 'Helvetica'; diff --git a/src/theme-contrast.scss b/src/theme-contrast.scss index fe40ed27..8d9ba0ce 100644 --- a/src/theme-contrast.scss +++ b/src/theme-contrast.scss @@ -14,6 +14,4 @@ $theme-contrast: mat.define-light-theme($theme-contrast-primary, $theme-contrast // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ -@include mat.all-legacy-component-themes($theme-contrast); @include mat.all-component-themes($theme-contrast); diff --git a/src/theme-dark.scss b/src/theme-dark.scss index 402feb5a..523bd4d0 100644 --- a/src/theme-dark.scss +++ b/src/theme-dark.scss @@ -14,6 +14,4 @@ $theme-dark: mat.define-dark-theme($theme-dark-primary, $theme-dark-accent, $the // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ -@include mat.all-legacy-component-themes($theme-dark); @include mat.all-component-themes($theme-dark); diff --git a/src/theme-light.scss b/src/theme-light.scss index 3ab7cfd0..5704d6ce 100644 --- a/src/theme-light.scss +++ b/src/theme-light.scss @@ -14,6 +14,4 @@ $theme-light: mat.define-light-theme($theme-light-primary, $theme-light-accent, // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/ -@include mat.all-legacy-component-themes($theme-light); @include mat.all-component-themes($theme-light); From a8ffc53c00b474da85a8639ec4c7159820907108 Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 23:19:32 +0100 Subject: [PATCH 4/8] angular upgrade: remove TODO related to ng material migration --- src/styles/partials/_forms.scss | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/styles/partials/_forms.scss b/src/styles/partials/_forms.scss index a3431bfe..62f5029f 100644 --- a/src/styles/partials/_forms.scss +++ b/src/styles/partials/_forms.scss @@ -70,13 +70,6 @@ textarea { } // radio input structure -// /* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ -// .mat-checkbox-label, -// .mat-checkbox-layout .mat-checkbox-label { -// max-width: 90vw; -// overflow-x: auto; -// @extend .clickable; -// } button, .button { font-family: 'Helvetica'; @@ -197,11 +190,6 @@ textarea { padding: 1em; } -/* TODO(mdc-migration): The following rule targets internal classes of checkbox that may no longer apply for the MDC version.*/ -mat-checkbox { - display: block; -} - .cdk-drag { cursor: pointer; From a726e3ed34d17d152bce3f672fe87bc2dfa0412b Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 23:35:58 +0100 Subject: [PATCH 5/8] angular upgrade: fix warning about theme declaration --- src/styles.scss | 2 +- src/theme-contrast.scss | 12 ++++++++++-- src/theme-dark.scss | 12 ++++++++++-- src/theme-light.scss | 12 ++++++++++-- 4 files changed, 31 insertions(+), 7 deletions(-) diff --git a/src/styles.scss b/src/styles.scss index 66b0be18..6a3538c2 100644 --- a/src/styles.scss +++ b/src/styles.scss @@ -6,8 +6,8 @@ // Include the common styles for Angular Material. We include this here so that you only // have to load a single css file for Angular Material in your app. // Be sure that you only ever include this mixin once! -@include mat.all-component-typographies(); @include mat.core(); +@include mat.all-component-typographies(); // import your custom themes @import 'theme-light.scss'; diff --git a/src/theme-contrast.scss b/src/theme-contrast.scss index 8d9ba0ce..bab31a1a 100644 --- a/src/theme-contrast.scss +++ b/src/theme-contrast.scss @@ -9,9 +9,17 @@ $theme-contrast-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400); $theme-contrast-warn: mat.define-palette(mat.$red-palette); // Create the theme object (a Sass map containing all of the palettes). -$theme-contrast: mat.define-light-theme($theme-contrast-primary, $theme-contrast-accent, $theme-contrast-warn); +$theme-contrast: mat.define-light-theme( + ( + color: ( + primary: $theme-contrast-primary, + accent: $theme-contrast-accent, + warn: $theme-contrast-warn, + ), + ) +); // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -@include mat.all-component-themes($theme-contrast); +// @include mat.all-component-themes($theme-contrast); diff --git a/src/theme-dark.scss b/src/theme-dark.scss index 523bd4d0..cbe5f4c3 100644 --- a/src/theme-dark.scss +++ b/src/theme-dark.scss @@ -9,9 +9,17 @@ $theme-dark-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400); $theme-dark-warn: mat.define-palette(mat.$red-palette); // Create the theme object (a Sass map containing all of the palettes). -$theme-dark: mat.define-dark-theme($theme-dark-primary, $theme-dark-accent, $theme-dark-warn); +$theme-dark: mat.define-dark-theme( + ( + color: ( + primary: $theme-dark-primary, + accent: $theme-dark-accent, + warn: $theme-dark-warn, + ), + ) +); // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -@include mat.all-component-themes($theme-dark); +// @include mat.all-component-themes($theme-dark); diff --git a/src/theme-light.scss b/src/theme-light.scss index 5704d6ce..134e3795 100644 --- a/src/theme-light.scss +++ b/src/theme-light.scss @@ -9,9 +9,17 @@ $theme-light-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400); $theme-light-warn: mat.define-palette(mat.$red-palette); // Create the theme object (a Sass map containing all of the palettes). -$theme-light: mat.define-light-theme($theme-light-primary, $theme-light-accent, $theme-light-warn); +$theme-light: mat.define-light-theme( + ( + color: ( + primary: $theme-light-primary, + accent: $theme-light-accent, + warn: $theme-light-warn, + ), + ) +); // Include theme styles for core and each component used in your app. // Alternatively, you can import and @include the theme mixins for each component // that you are using. -@include mat.all-component-themes($theme-light); +// @include mat.all-component-themes($theme-light); From 4f38c78a2b05e7cf2ccbbfd69311812f217c400f Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 23:54:22 +0100 Subject: [PATCH 6/8] angular upgrade: fix division warning --- src/styles/partials/_forms.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/partials/_forms.scss b/src/styles/partials/_forms.scss index 62f5029f..2396ffca 100644 --- a/src/styles/partials/_forms.scss +++ b/src/styles/partials/_forms.scss @@ -363,7 +363,7 @@ label { } .people { - max-width: $main-column-width/2; + max-width: calc($main-column-width / 2); } .bar-div { From 54329467c4ce6adb3cea942e7855cd2860e58d76 Mon Sep 17 00:00:00 2001 From: bmartins Date: Fri, 17 Mar 2023 23:55:39 +0100 Subject: [PATCH 7/8] angular upgrade: fix material warn theme duplicate - Comment theme import due to same color palette use --- src/styles.scss | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/styles.scss b/src/styles.scss index 6a3538c2..c4ea34dd 100644 --- a/src/styles.scss +++ b/src/styles.scss @@ -15,14 +15,14 @@ @import 'theme-contrast.scss'; .theme-light { - @include mat.all-component-themes($theme-light); -} -.theme-dark { - @include mat.all-component-themes($theme-dark); -} -.theme-contrast { - @include mat.all-component-themes($theme-contrast); + @include mat.all-component-colors($theme-light); } +// .theme-dark { +// @include mat.all-component-colors($theme-dark); +// } +// .theme-contrast { +// @include mat.all-component-colors($theme-contrast); +// } /* You can add global.scss styles to this file, and also import other style files From 434c0f4cf99a6144dd2de960cb25af718cb08b79 Mon Sep 17 00:00:00 2001 From: bmartins Date: Wed, 22 Mar 2023 14:05:39 +0100 Subject: [PATCH 8/8] fix(CI): ensure at least build step work --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 10ddf280..f4bc27a6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ build: before_script: - yarn script: - - yarn run build:prod:demobliss + - yarn run build:prod cache: policy: pull