santiagorodriguez96
a340e653df
[Glitch] Add WebAuthn as an alternative 2FA method
...
Port CSS changes from e8d41bc2fe
2020-08-30 17:21:16 +02:00
Tdxdxoz
bf55b5463a
[Glitch] Fix: also use custom private boost icon for detailed status
...
Port a3ec9af9b0
2020-08-30 16:51:16 +02:00
Daigo 3 Dango
72b1d5fdc5
[Glitch] Better manage subscriptionCounters
...
Port 9669557be1
2020-08-30 16:35:33 +02:00
proxy
3bbf6b1519
[Glitch] reword "boost to original audience" as per tootsuite#14596
...
Port 46210a65d1
2020-08-30 16:34:38 +02:00
Takeshi Umeda
cd806663af
[Glitch] Fix click range discrepancies in gifv
...
Port debf6ae316
2020-08-30 16:31:41 +02:00
ThibG
45d1f34a30
[Glitch] Fix scrolling issues when closing some dropdown menus
...
Port c7cfd4e67a
2020-08-30 16:31:02 +02:00
Thibaut Girka
8c3c27bf06
Merge branch 'master' into glitch-soc/merge-upstream
...
Conflicts:
- `app/controllers/accounts_controller.rb`:
Upstream change too close to a glitch-soc change related to
instance-local toots. Merged upstream changes.
- `app/services/fan_out_on_write_service.rb`:
Minor conflict due to glitch-soc's handling of Direct Messages,
merged upstream changes.
- `yarn.lock`:
Not really a conflict, caused by glitch-soc-only dependencies
being textually too close to updated upstream dependencies.
Merged upstream changes.
2020-08-30 16:13:08 +02:00
Eugen Rochko
52157fdcba
Add support for dereferencing objects through bearcaps ( #14683 )
2020-08-30 12:34:20 +02:00
Eugen Rochko
ce8f33dd2f
Fix inefficiencies in fan-out-on-write service ( #14682 )
2020-08-30 12:33:59 +02:00
Eugen Rochko
bf477cee9f
Fix videos with near-60 fps being rejected ( #14684 )
...
Fix #14668
2020-08-30 01:54:30 +02:00
Thibaut Girka
30632adf9e
Fix replying to some remote toots switching to local-only
2020-08-29 19:57:32 +02:00
Aurelia
8630afb468
fix: make Procfile compatible with herokuish ( #12685 )
...
Co-authored-by: Aurelia <aurelia@serenitylabs.cloud>
2020-08-29 19:00:30 +02:00
Akihiko Odaki
64ef37b89d
Introduce ApplicationController#cache_collection_paginated_by_id ( #14677 )
...
* Replace incorrect use of distinct with group
Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
are incorrect for the current version of Rails.
ActiveRecord::QueryMethods#group provides the expected behavior and
benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.
* Introduce ApplicationController#cache_collection_paginated_by_id
ApplicationController#cache_collection_paginated_by_id fuses
ApplicationController#cache_collection and Paginable.paginate_by_id.
An advantage of this method is that it prevents from modifying scope which
Paginable.paginate_by_id may provide.
ApplicationController#cache_collection always return an array and there
is no possibility of the scope modification. It is also clear for a
programmer, considering the implication of "cache".
This method can also emit more efficient queries by using
Cacheable.cache_ids before calling Paginable.paginate_by_id.
2020-08-28 12:31:56 +02:00
Akihiko Odaki
b63ede5005
Eagerly load statuses with the main query in Api::V1::BookmarksController ( #14674 )
...
This is same with commit 552e886b64
2020-08-28 12:30:23 +02:00
Akihiko Odaki
e26e7a1cb5
Replace incorrect use of distinct with group ( #14675 )
...
Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
are incorrect for the current version of Rails.
ActiveRecord::QueryMethods#group provides the expected behavior and
benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.
2020-08-28 12:29:59 +02:00
Akihiko Odaki
552e886b64
Eagerly load statuses with the main query in Api::V1::FavouritesController ( #14673 )
...
The old implementation had two queries:
1. The query constructed in Api::V1::FavouritesController#results
2. The query constructed in #cached_favourites, which is merged with 1.
Both of them are issued againt PostgreSQL. The combination of the two
queries caused the following problems:
- The small window between the two queries involves race conditions.
- Minor performance inefficiency.
Moreover, the construction of query 2, which involves merging with query
1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
returns an array when min_id parameter is specified. The behavior prevents
from merging the query, and in the real world, ActiveRecord simply ignores
the merge (!), which results in querying the entire scan of statuses and
favourites table.
This change fixes these issues by simply letting query 1 get all the works
done.
2020-08-28 09:27:33 +02:00
dependabot[bot]
a10f53aa69
Bump events from 3.1.0 to 3.2.0 ( #14653 )
...
Bumps [events](https://github.com/Gozala/events ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/Gozala/events/releases )
- [Changelog](https://github.com/Gozala/events/blob/master/History.md )
- [Commits](https://github.com/Gozala/events/compare/v3.1.0...v3.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 09:41:37 +09:00
dependabot[bot]
5a9b1015a5
Bump jest from 26.4.0 to 26.4.2 ( #14648 )
...
Bumps [jest](https://github.com/facebook/jest ) from 26.4.0 to 26.4.2.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v26.4.0...v26.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 01:53:32 +09:00
dependabot[bot]
9a47d59595
Bump @clusterws/cws from 2.0.0 to 3.0.0 ( #14630 )
...
Bumps [@clusterws/cws](https://github.com/ClusterWS/cWS ) from 2.0.0 to 3.0.0.
- [Release notes](https://github.com/ClusterWS/cWS/releases )
- [Changelog](https://github.com/ClusterWS/cWS/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ClusterWS/cWS/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 01:32:53 +09:00
dependabot[bot]
ab75728c9f
Bump browserslist from 4.13.0 to 4.14.0 ( #14652 )
...
Bumps [browserslist](https://github.com/browserslist/browserslist ) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/browserslist/browserslist/releases )
- [Changelog](https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md )
- [Commits](https://github.com/browserslist/browserslist/compare/4.13.0...4.14.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 01:12:13 +09:00
dependabot[bot]
14bc6d63cf
Bump create-ecdh from 4.0.3 to 4.0.4 ( #14649 )
...
Bumps [create-ecdh](https://github.com/crypto-browserify/createECDH ) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/crypto-browserify/createECDH/releases )
- [Commits](https://github.com/crypto-browserify/createECDH/compare/v4.0.3...v4.0.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 00:41:15 +09:00
dependabot[bot]
9f5d5c378d
Bump css-loader from 3.6.0 to 4.2.2 ( #14664 )
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 3.6.0 to 4.2.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.6.0...v4.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 00:02:03 +09:00
dependabot[bot]
58d5175f75
Bump compression-webpack-plugin from 4.0.0 to 5.0.1 ( #14647 )
...
Bumps [compression-webpack-plugin](https://github.com/webpack-contrib/compression-webpack-plugin ) from 4.0.0 to 5.0.1.
- [Release notes](https://github.com/webpack-contrib/compression-webpack-plugin/releases )
- [Changelog](https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/compression-webpack-plugin/compare/v4.0.0...v5.0.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 00:01:46 +09:00
dependabot[bot]
8dc66ca473
Bump imports-loader from 0.8.0 to 1.1.0 ( #14323 )
...
* Bump imports-loader from 0.8.0 to 1.1.0
Bumps [imports-loader](https://github.com/webpack-contrib/imports-loader ) from 0.8.0 to 1.1.0.
- [Release notes](https://github.com/webpack-contrib/imports-loader/releases )
- [Changelog](https://github.com/webpack-contrib/imports-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/imports-loader/compare/v0.8.0...v1.1.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Migrate new syntax
* Add semicolon
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2020-08-25 22:50:47 +09:00
dependabot[bot]
3c726924c9
Bump sass-loader from 8.0.2 to 9.0.3 ( #14637 )
...
Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader ) from 8.0.2 to 9.0.3.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases )
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v8.0.2...v9.0.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:51:51 +09:00
dependabot[bot]
2f3915a508
Bump aggregate-error from 3.0.1 to 3.1.0 ( #14654 )
...
Bumps [aggregate-error](https://github.com/sindresorhus/aggregate-error ) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/sindresorhus/aggregate-error/releases )
- [Commits](https://github.com/sindresorhus/aggregate-error/compare/v3.0.1...v3.1.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:48:39 +09:00
dependabot[bot]
22483a70cf
Bump js-base64 from 2.6.2 to 2.6.4 ( #14650 )
...
Bumps [js-base64](https://github.com/dankogai/js-base64 ) from 2.6.2 to 2.6.4.
- [Release notes](https://github.com/dankogai/js-base64/releases )
- [Commits](https://github.com/dankogai/js-base64/compare/2.6.2...2.6.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:44:10 +09:00
dependabot[bot]
1762cb8478
Bump eventemitter3 from 4.0.4 to 4.0.5 ( #14646 )
...
Bumps [eventemitter3](https://github.com/primus/eventemitter3 ) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/primus/eventemitter3/releases )
- [Commits](https://github.com/primus/eventemitter3/compare/4.0.4...4.0.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:43:00 +09:00
dependabot[bot]
fc47d4ce02
Bump postgres-date from 1.0.5 to 1.0.6 ( #14642 )
...
Bumps [postgres-date](https://github.com/bendrucker/postgres-date ) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/bendrucker/postgres-date/releases )
- [Commits](https://github.com/bendrucker/postgres-date/compare/v1.0.5...v1.0.6 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:38:20 +09:00
dependabot[bot]
b453b7041d
Bump autoprefixer from 9.8.5 to 9.8.6 ( #14641 )
...
Bumps [autoprefixer](https://github.com/postcss/autoprefixer ) from 9.8.5 to 9.8.6.
- [Release notes](https://github.com/postcss/autoprefixer/releases )
- [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/postcss/autoprefixer/compare/9.8.5...9.8.6 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:35:57 +09:00
dependabot[bot]
22e2baa458
Bump @babel/runtime from 7.10.5 to 7.11.2 ( #14639 )
...
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime ) from 7.10.5 to 7.11.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.11.2/packages/babel-runtime )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:33:31 +09:00
dependabot[bot]
5653435bb9
Bump @babel/plugin-transform-runtime from 7.10.5 to 7.11.0 ( #14645 )
...
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime ) from 7.10.5 to 7.11.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.11.0/packages/babel-plugin-transform-runtime )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:32:29 +09:00
dependabot[bot]
65c53f4475
Bump browserify-sign from 4.2.0 to 4.2.1 ( #14636 )
...
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/crypto-browserify/browserify-sign/releases )
- [Commits](https://github.com/crypto-browserify/browserify-sign/compare/v4.2.0...v4.2.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:30:11 +09:00
dependabot[bot]
6d348746f3
Bump babel-jest from 26.1.0 to 26.3.0 ( #14634 )
...
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest ) from 26.1.0 to 26.3.0.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v26.3.0/packages/babel-jest )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:15:38 +09:00
dependabot[bot]
37ad41a0f9
Bump copy-webpack-plugin from 6.0.2 to 6.0.3 ( #14633 )
...
Bumps [copy-webpack-plugin](https://github.com/webpack-contrib/copy-webpack-plugin ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/webpack-contrib/copy-webpack-plugin/releases )
- [Changelog](https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/copy-webpack-plugin/compare/v6.0.2...v6.0.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:13:39 +09:00
dependabot[bot]
b0115fc531
Bump minizlib from 2.1.0 to 2.1.2 ( #14632 )
...
Bumps [minizlib](https://github.com/isaacs/minizlib ) from 2.1.0 to 2.1.2.
- [Release notes](https://github.com/isaacs/minizlib/releases )
- [Commits](https://github.com/isaacs/minizlib/compare/v2.1.0...v2.1.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:13:13 +09:00
dependabot[bot]
85d268df9e
Bump webpack from 4.44.0 to 4.44.1 ( #14628 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.44.0 to 4.44.1.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.44.0...v4.44.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:10:01 +09:00
dependabot[bot]
22081567ab
Bump net-ldap from 0.16.2 to 0.16.3 ( #14627 )
...
Bumps [net-ldap](https://github.com/ruby-ldap/ruby-net-ldap ) from 0.16.2 to 0.16.3.
- [Release notes](https://github.com/ruby-ldap/ruby-net-ldap/releases )
- [Changelog](https://github.com/ruby-ldap/ruby-net-ldap/blob/master/History.rdoc )
- [Commits](https://github.com/ruby-ldap/ruby-net-ldap/compare/v0.16.2...v0.16.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 21:02:06 +09:00
dependabot[bot]
27a3202b74
Bump elasticsearch from 7.8.1 to 7.9.0 ( #14625 )
...
Bumps [elasticsearch](https://github.com/elastic/elasticsearch-ruby ) from 7.8.1 to 7.9.0.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases )
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.8.1...v7.9.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:59:39 +09:00
dependabot[bot]
eeff3bf9e0
Bump elasticsearch-transport from 7.8.1 to 7.9.0 ( #14624 )
...
Bumps [elasticsearch-transport](https://github.com/elastic/elasticsearch-ruby ) from 7.8.1 to 7.9.0.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases )
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.8.1...v7.9.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:58:59 +09:00
dependabot[bot]
7ab7fc7577
Bump redis-namespace from 1.7.0 to 1.8.0 ( #14623 )
...
Bumps [redis-namespace](https://github.com/resque/redis-namespace ) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/resque/redis-namespace/releases )
- [Changelog](https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md )
- [Commits](https://github.com/resque/redis-namespace/compare/v1.7.0...v1.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:57:44 +09:00
dependabot[bot]
9a1c350924
Bump jwt from 2.2.1 to 2.2.2 ( #14621 )
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.2.1...v2.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:53:09 +09:00
dependabot[bot]
fc52962667
Bump webpacker from 5.2.0 to 5.2.1 ( #14619 )
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.2.0...v5.2.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:49:20 +09:00
dependabot[bot]
5678b195ff
Bump oj from 3.10.8 to 3.10.12 ( #14620 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.10.8 to 3.10.12.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.10.8...v3.10.12 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:45:57 +09:00
dependabot[bot]
32567acdd0
Bump aws-sdk-core from 3.104.3 to 3.104.4 ( #14618 )
...
Bumps [aws-sdk-core](https://github.com/aws/aws-sdk-ruby ) from 3.104.3 to 3.104.4.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-25 20:44:58 +09:00
Akihiko Odaki
41eeb9ebaa
Use Status.group instead of Status.distinct in HashQueryService ( #14662 )
...
DISTINCT clause removes duplicated records according to all the selected
attributes. In reality, it can remove duplicated records only looking at
statuses.id, but the clause confuses the query planner and yields
insufficient performance.
The behavior is also problematic if the scope produced by HashQueryService
is used to query columns without id (using pluck method, for example). The
scope is expected to contain unique statuses, but the uniquness will be
evaluated with some arbitrary columns other than id.
GROUP BY clause resolves those problem by explicitly specifying the
column to take into account for the record distinction.
A workaround for the problem of DISTINCT clause in
Api::V1::Timelines::TagController is no longer necessary and removed.
2020-08-25 13:39:35 +02:00
santiagorodriguez96
9cadd40cf4
refactor: add email previews for WebAuthn emails ( #14658 )
...
This is a leftover for the work done in #14466 .
2020-08-25 01:21:11 +02:00
Daigo 3 Dango
abb14579a7
Stop installing libssl-dev for build ( #14660 )
...
libssl-dev is provided with the stack image in build time and
conflicts in building openssl Gem for webauthn Gem added with #14466 .
2020-08-25 01:20:59 +02:00
Thibaut Girka
f1d31cf18d
Fix spacing around reblog counter in detailed statuses
...
And bring the whole thing closer to upstream's code.
2020-08-24 20:03:37 +02:00
ThibG
b241f20bd2
Add support for latest HTTP Signatures spec draft ( #14556 )
...
* Add support for latest HTTP Signatures spec draft
https://www.ietf.org/id/draft-ietf-httpbis-message-signatures-00.html
- add support for the “hs2019” signature algorithm (assumed to be equivalent
to RSA-SHA256, since we do not have a mechanism to specify the algorithm
within the key metadata yet)
- add support for (created) and (expires) pseudo-headers and related
signature parameters, when using the hs2019 signature algorithm
- adjust default “headers” parameter while being backwards-compatible with
previous implementation
- change the acceptable time window logic from 12 hours surrounding the “date”
header to accepting signatures created up to 1 hour in the future and
expiring up to 1 hour in the past (but only allowing expiration dates up to
12 hours after the creation date)
This doesn't conform with the current draft, as it doesn't permit accounting
for clock skew.
This, however, should be addressed in a next version of the draft:
https://github.com/httpwg/http-extensions/pull/1235
* Add additional signature requirements
* Rewrite signature params parsing using Parslet
* Make apparent which signature algorithm Mastodon on verification failure
Mastodon uses RSASSA-PKCS1-v1_5, which is not recommended for new applications,
and new implementers may thus unknowingly use RSASSA-PSS.
* Add workaround for PeerTube's invalid signature header
The previous parser allowed incorrect Signature headers, such as
those produced by old versions of the `http-signature` node.js package,
and seemingly used by PeerTube.
This commit adds a workaround for that.
* Fix `signature_key_id` raising an exception
Previously, parsing failures would result in `signature_key_id` being nil,
but the parser changes made that result in an exception.
This commit changes the `signature_key_id` method to return `nil` in case
of parsing failures.
* Move extra HTTP signature helper methods to private methods
* Relax (request-target) requirement to (request-target) || digest
This lets requests from Plume work without lowering security significantly.
2020-08-24 18:21:07 +02:00
