mirror of https://framagit.org/tykayn/mastodon.git
31f7c3fc5d
* Summary: fix slowness due to layout thrashing when reloading a large set of status updates in order to limit the maximum size of a status in a list view (e.g. the home timeline), so as to avoid having to scroll all the way through an abnormally large status update (see https://github.com/tootsuite/mastodon/pull/8205), the following steps are taken: •the element containing the status is rendered in the browser •its height is calculated, to determine if it exceeds the maximum height threshold. Unfortunately for performance, these steps are carried out in the componentDidMount(/Update) method, which also performs style modifications on the element. The combination of height request and style modification during javascript evaluation in the browser leads to layout-thrashing, where the elements are repeatedly re-laid-out (see https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing & https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Performance_best_practices_for_Firefox_fe_engineers). The solution implemented here is to memoize the collapsed state in Redux the first time the status is seen (e.g. when fetched as part of a small batch, to populate the home timeline) , so that on subsequent re-renders, the value can be queried, rather than recalculated. This strategy is derived from https://github.com/tootsuite/mastodon/pull/4439 & https://github.com/tootsuite/mastodon/pull/4909, and should resolve https://github.com/tootsuite/mastodon/issues/12455. Andrew Lin (https://github.com/onethreeseven) is thanked for his assistance in root cause analysis and solution brainstorming * remove getSnapshotBeforeUpdate from status * remove componentWillUnmount from status * persist last-intersected status update and restore when ScrollableList is restored e.g. when navigating from home-timeline to a status conversational thread and <Back again * cache currently-viewing status id to avoid calling redux with identical value * refactor collapse toggle to pass explicit boolean |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| account.js | ||
| attachment_list.js | ||
| autosuggest_emoji.js | ||
| autosuggest_hashtag.js | ||
| autosuggest_input.js | ||
| autosuggest_textarea.js | ||
| avatar.js | ||
| avatar_composite.js | ||
| avatar_overlay.js | ||
| button.js | ||
| column.js | ||
| column_back_button.js | ||
| column_back_button_slim.js | ||
| column_header.js | ||
| display_name.js | ||
| domain.js | ||
| dropdown_menu.js | ||
| error_boundary.js | ||
| gifv.js | ||
| hashtag.js | ||
| icon.js | ||
| icon_button.js | ||
| icon_with_badge.js | ||
| intersection_observer_article.js | ||
| load_gap.js | ||
| load_more.js | ||
| load_pending.js | ||
| loading_indicator.js | ||
| media_gallery.js | ||
| missing_indicator.js | ||
| modal_root.js | ||
| permalink.js | ||
| poll.js | ||
| radio_button.js | ||
| regeneration_indicator.js | ||
| relative_timestamp.js | ||
| scrollable_list.js | ||
| setting_text.js | ||
| status.js | ||
| status_action_bar.js | ||
| status_content.js | ||
| status_list.js | ||