Claire e38fc319dc
Refactor and improve tests (#17386)
* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.
2022-01-28 00:46:42 +01:00
..
2022-01-28 00:46:42 +01:00
2021-11-25 13:07:38 +01:00
2018-10-04 12:36:53 +02:00
2017-06-19 11:31:37 +02:00
2018-10-04 12:36:53 +02:00
2018-10-04 12:36:53 +02:00
2020-06-02 19:24:53 +02:00
2017-06-19 01:38:50 +02:00
2020-10-12 16:33:49 +02:00
2018-10-04 12:36:53 +02:00
2018-10-04 12:36:53 +02:00
2017-04-05 00:29:56 +02:00
2018-10-04 12:36:53 +02:00
2020-06-02 19:24:53 +02:00
2019-03-03 22:18:23 +01:00
2018-10-04 12:36:53 +02:00
2021-02-21 19:50:12 +01:00
2020-06-02 19:24:53 +02:00
2021-04-25 06:33:28 +02:00