mastodon/app
Akihiko Odaki 552e886b64
Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673)
The old implementation had two queries:
1. The query constructed in Api::V1::FavouritesController#results
2. The query constructed in #cached_favourites, which is merged with 1.

Both of them are issued againt PostgreSQL. The combination of the two
queries caused the following problems:
- The small window between the two queries involves race conditions.
- Minor performance inefficiency.

Moreover, the construction of query 2, which involves merging with query
1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id
returns an array when min_id parameter is specified. The behavior prevents
from merging the query, and in the real world, ActiveRecord simply ignores
the merge (!), which results in querying the entire scan of statuses and
favourites table.

This change fixes these issues by simply letting query 1 get all the works
done.
2020-08-28 09:27:33 +02:00
..
chewy Change tootctl search deploy algorithm (#14300) 2020-07-14 18:10:35 +02:00
controllers Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673) 2020-08-28 09:27:33 +02:00
helpers Add a visibility icon to status (#14123) 2020-06-25 22:43:59 +02:00
javascript Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
lib Fix dereferencing remote statuses not using the correct account (#14656) 2020-08-24 16:56:21 +02:00
mailers Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
models Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
policies Add ability to delete files uploaded for settings in admin UI (#13192) 2020-03-08 16:00:24 +01:00
presenters Add user notes on accounts (#14148) 2020-06-30 19:19:50 +02:00
serializers Add thumbnail_remote_url in MediaAttachment REST response (#14358) 2020-07-19 19:53:31 +02:00
services Use Status.group instead of Status.distinct in HashQueryService (#14662) 2020-08-25 13:39:35 +02:00
validators Improve email address validation (#14565) 2020-08-12 12:40:25 +02:00
views Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
workers Changed retries and rescued in ActivityPub::ProcessingWorker (#14355) 2020-07-20 11:26:12 +02:00