Update base64 to the latest version, move to a dedicated directory #4

pilou · 2022-06-07T10:53:12+02:00

pilou commented

2022-06-07 10:53:12 +02:00

Created from https://projects.duckcorp.org/issues/765 in order to facilitate the review.

pilou added 4 commits 2022-06-07 10:53:14 +02:00

c6a872ed61

Add bipgenconfig.1 to dist_man_MANS

Fix 1df884545f

0db4305311

update base64 files: resync from the src project

The allocated buffer size was slightly overestimated due to unused line
feeds taken in account.

I kept the differences with the original project as small as possible in
order to make the next synchronization easy.

07084a5902

Be as close as possible to base64 lib, and use new function to reduce changes.

* use new base64_encode_no_lf() function having no line returns
* fix irc_server_sasl_authenticate(): add missing free(raw_str)

fa4ed1f006

Move base64 files to a dedicated dir in utils/

pilou commented

2022-06-07 10:58:51 +02:00

@Kyoshiro the proposed tree below seems a bit too much complicated:

$ tree -d src/
src/
[...]
├── util.c
├── util.h
└── utils
    └── b64
        ├── base64.c
        ├── base64.h
        ├── includes.h
        ├── os.h
        └── utils
            └── common.h

compared to the current one:

src/
[...]
├── util.c
├── util.h
└── utils
    ├── base64.c
    └── base64.h

@Kyoshiro what do you think of the following tree ?

src/
[...]
├── util.c
├── util.h
└── b64
    ├── base64.c
    ├── base64.h
    ├── includes.h
    ├── os.h
    └── common.h

@Kyoshiro the proposed tree below seems a bit too much complicated: <pre> $ tree -d src/ src/ [...] ├── util.c ├── util.h └── utils └── b64 ├── base64.c ├── base64.h ├── includes.h ├── os.h └── utils └── common.h </pre> compared to the current one: <pre> src/ [...] ├── util.c ├── util.h └── utils ├── base64.c └── base64.h </pre> @Kyoshiro what do you think of the following tree ? <pre> src/ [...] ├── util.c ├── util.h └── b64 ├── base64.c ├── base64.h ├── includes.h ├── os.h └── common.h </pre>

pilou requested review from Kyoshiro 2022-06-07 10:59:07 +02:00

Kyoshiro commented

2024-02-06 00:54:53 +01:00

You're right, I'll fix that in a followup.

Kyoshiro changed title from ~~Add copyright data for base64 files and update to the new version~~ to WIP Add copyright data for base64 files and update to the new version

2024-02-07 13:26:30 +01:00

Kyoshiro force-pushed #765_Add_copyright_data_for_base64_files_and_update_to_the_new_version from fa4ed1f006 to f1214dbfb5

2024-02-19 07:26:39 +01:00

Compare

Kyoshiro changed title from ~~WIP Add copyright data for base64 files and update to the new version~~ to Update base64 to the latest version, move to a dedicated directory

2024-02-19 07:28:52 +01:00

Kyoshiro commented

2024-02-19 07:36:47 +01:00

Okay! Here's what I did:

rebased against current master
kept your initial commit untouched
moved the lib to src/b64 directory
updated the lib and added required files (while not adding subdirectory for a single include "utils/common.h" 😆)
kept the changes to a bare minimum (apart from stripping unused code)
updated the URL for the base64 source
added a lastsync status file to avoid adding lines to the library's files themselves
fixed the missing free() in irc_server_sasl_authenticate
used new base64_encode_no_lf() function with no line returns

Let me know what you think 😉

Okay! Here's what I did: * rebased against current master * kept your initial commit untouched * moved the lib to src/b64 directory * updated the lib and added required files (while not adding subdirectory for a single `include "utils/common.h"` 😆) * kept the changes to a bare minimum (apart from stripping unused code) * updated the URL for the base64 source * added a lastsync status file to avoid adding lines to the library's files themselves * fixed the missing free() in `irc_server_sasl_authenticate` * used new base64_encode_no_lf() function with no line returns Let me know what you think 😉

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bip/bip#4