bortzmeyer/check_expire
2
1
Fork 2
Code Issues Pull Requests Projects Releases Wiki Activity

Fix two failing tests #6

Closed
Seb35 wants to merge 0 commits from Seb35/check_expire:pull-request-6 into master
pull from: Seb35/check_expire:pull-request-6
merge into: bortzmeyer:master
Conversation 1 Commits - Files Changed -
Seb35 commented 2022-12-18 20:09:18 +01:00
First-time contributor
Copy Link

By the way, converted the timeout parameter to a float to be able to test (I cannot find an RDAP server returning a timeout when it is 1 second) and it should not be harmful.

An implementation detail: the continue is needed because response is not defined when the timeout is trigerred.

By the way, converted the timeout parameter to a float to be able to test (I cannot find an RDAP server returning a timeout when it is 1 second) and it should not be harmful. An implementation detail: the `continue` is needed because `response` is not defined when the timeout is trigerred.
Seb35 added 1 commit 2022-12-18 20:09:20 +01:00 
By the way, converted the timeout parameter to a float.
bortzmeyer commented 2024-06-16 20:38:50 +02:00
Owner
Copy Link

Merged just now, thanks.

Merged just now, thanks.
bortzmeyer closed this pull request 2024-06-16 20:38:50 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bortzmeyer/check_expire#6
No description provided.
Delete Branch "Seb35/check_expire:pull-request-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?