hardcoresushi/libcryfs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Comment out failing test cases instead of DISABLING them. Disabling is reserved for working, but slow tests

Browse Source
This commit is contained in:
Sebastian Messmer 2015-12-11 12:31:57 +01:00
parent 1121467b31
commit a68446f983
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/fuse/closeFile/FuseCloseTest.cpp
View File

@ -78,7 +78,7 @@ INSTANTIATE_TEST_CASE_P(FuseCloseTest, FuseCloseTest, Values(0, 1, 2, 100, 1024*
//TODO Figure out what's wrong and enable this test
//Disabled, because it is flaky. libfuse seems to not send the release() event sometimes.
TEST_P(FuseCloseTest, DISABLED_CloseFile) {
/*TEST_P(FuseCloseTest, CloseFile) {
Barrier barrier;
ReturnIsFileOnLstat(FILENAME);
@ -96,4 +96,4 @@ TEST_P(FuseCloseTest, DISABLED_CloseFile) {
// Wait, until fuse release() was called, so we can check for the function call expectation.
barrier.WaitAtMost(seconds(10));
}
}*/

4
test/fuse/createAndOpenFile/FuseCreateAndOpenFlagsTest.cpp
View File

@ -11,7 +11,7 @@ class FuseCreateAndOpenFlagsTest: public FuseCreateAndOpenTest, public WithParam
INSTANTIATE_TEST_CASE_P(FuseCreateAndOpenFlagsTest, FuseCreateAndOpenFlagsTest, Values(O_RDWR, O_RDONLY, O_WRONLY));
//TODO Disabled because it doesn't seem to work. Fuse doesn't seem to pass flags to create(). Why?
TEST_P(FuseCreateAndOpenFlagsTest, DISABLED_testFlags) {
/*TEST_P(FuseCreateAndOpenFlagsTest, testFlags) {
ReturnDoesntExistOnLstat(FILENAME);
EXPECT_CALL(fsimpl, createAndOpenFile(StrEq(FILENAME), OpenFlagsEq(GetParam()), _, _))
.Times(1).WillOnce(Return(0));
@ -19,4 +19,4 @@ TEST_P(FuseCreateAndOpenFlagsTest, DISABLED_testFlags) {
ReturnIsFileOnFstat(0);
CreateAndOpenFile(FILENAME, GetParam());
}
}*/

4
test/impl/FuseOpenFileListTest.cpp
View File

@ -89,7 +89,7 @@ TEST_F(FuseOpenFileListTest, Open3AndGet) {
}
//TODO Test case fails. Disabled it. Figure out why and reenable.
TEST_F(FuseOpenFileListTest, DISABLED_DestructOnClose) {
/*TEST_F(FuseOpenFileListTest, DestructOnClose) {
int id = open();
MockOpenFile *openFile = dynamic_cast<MockOpenFile*>(list.get(id));
@ -97,7 +97,7 @@ TEST_F(FuseOpenFileListTest, DISABLED_DestructOnClose) {
EXPECT_FALSE(openFile->destructed);
list.close(id);
EXPECT_TRUE(openFile->destructed);
}
}*/
TEST_F(FuseOpenFileListTest, GetClosedItemOnEmptyList) {
int id = open();