1472 Commits (8cb104f004cc5d3343bc3b5ef2187c1830e00f19)

 

All Branches   

Search

Author	SHA1	Message	Date
Jakob Unterwurzacher	e276e255dc	tests: split mount_unmount.go from helpers.go ... With the FD leak logic, the mount/unmount functions have become complex enough to give them their own file.	4 years ago
Jakob Unterwurzacher	10de105c13	tests: detect fd leaks on unmount ... For now, this only prints a message but does not fail the tests.	4 years ago
Jakob Unterwurzacher	cd0ec342b9	fusefrontend: fix fd leak in error path	4 years ago
Jakob Unterwurzacher	77c3df48ef	fusefrontend: fix fd leak in Access() ... Thanks @slackner! Fixes https://github.com/rfjakob/gocryptfs/issues/306	4 years ago
Jakob Unterwurzacher	887d5aa8e7	tests: teach ListFds() to check other processes	4 years ago
Jakob Unterwurzacher	817c485bb7	tests: save gocryptfs process id in test_helpers.MountPID ... This will allow to tests to monitor fd usage and maybe other things.	4 years ago
Jakob Unterwurzacher	60e7a0ca9f	fusefrontend: xattr: fix hang on FIFOs ... An Open() a fifo blocks until it is opened for writing. This meant that xattr operations on FIFOs would block. Pass O_NONBLOCK to fix that, and add a test.	4 years ago
Jakob Unterwurzacher	1d5500c3db	fusefrontend: only compile getBackingPath() on Darwin ... This function is NOT symlink-safe. Darwin needs it because it lacks fgetxattr(2) and friends.	4 years ago
Jakob Unterwurzacher	c3adf9729d	fusefrontend: make ListXAttr symlink-safe on Linux ... Uses /proc/self/fd.	4 years ago
Jakob Unterwurzacher	d3ae87fa2b	fusefrontend: make RemoveXAttr() symlink-safe ... Uses /proc/self/fd on Linux.	4 years ago
Jakob Unterwurzacher	810d2a8b47	fusefrontend: make SetXAttr() symlink-safe on Linux ... Uses the /proc/self/fd trick.	4 years ago
Jakob Unterwurzacher	2286372603	fusefrontend: make GetXAttr() symlink-safe on Linux ... Uses the /proc/self/fd trick, which does not work on Darwin.	4 years ago
Jakob Unterwurzacher	b97d7d1d33	tests: add Flistxattr/Fgetxattr/Fremovexattr tests ... Test for the upcoming fd-based xattr support.	4 years ago
Jakob Unterwurzacher	a355670ca2	fusefrontend: make Utimens symlink-safe ... unix.UtimesNanoAt now also exists on Darwin, yay!	4 years ago
Jakob Unterwurzacher	abbdaa8ea4	fusefrontend: fix compile failure on Darwin ... Failure was: + GOOS=darwin + GOARCH=amd64 + go build -tags without_openssl # github.com/rfjakob/gocryptfs/internal/fusefrontend internal/fusefrontend/fs_dir.go:159:60: cannot use origMode | 448 (type uint16) as type uint32 in argument to syscallcompat.Fchmodat internal/fusefrontend/fs_dir.go:170:33: cannot use origMode (type uint16) as type uint32 in argument to syscallcompat.Fchmodat	4 years ago
Jakob Unterwurzacher	d4b7f42c3b	fusefrontend: mark Truncate, Unlink, Symlink symlink-safe ... No changes needed.	4 years ago
Jakob Unterwurzacher	436f918c21	fusefrontend: make Rmdir symlink-safe ... Now uses Unlinkat.	4 years ago
Jakob Unterwurzacher	2de3851abd	nametransform: rename WriteLongName() -> WriteLongNameAt() ... And also rename DeleteLongName() -> DeleteLongNameAt(). The naming follow the names open the openat() etc syscalls.	4 years ago
Jakob Unterwurzacher	4fae240153	fusefrontend: make Readlink() symlink-safe ... Now symlink-safe through Readlinkat().	4 years ago
Jakob Unterwurzacher	21f1f858b9	fusefrontend: make OpenDir() symlink-safe ... Interestingly, little or no performance impact: $ ./benchmark.bash Testing gocryptfs at /tmp/benchmark.bash.39W: gocryptfs v1.6-42-g30c2349-dirty; go-fuse v20170619-66-g6df8ddc; 2018-11-04 go1.11 Downloading linux-3.0.tar.gz /tmp/linux-3.0.tar.gz 100%[=========================================================================>] 92.20M 2.93MB/s in 31s 2018-11-04 21:44:44 URL:https://cdn.kernel.org/pub/linux/kernel/v3.0/linux-3.0.tar.gz [96675825/96675825] -> "/tmp/linux-3.0.tar.gz" [1] WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.1808 s, 222 MB/s READ: 262144000 bytes (262 MB, 250 MiB) copied, 0.866438 s, 303 MB/s UNTAR: 24.745 MD5: 12.050 LS: 3.525 RM: 9.544 Note: kernel has been updated: $ uname -a Linux brikett 4.18.16-200.fc28.x86_64 #1 SMP Sat Oct 20 23:53:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux	4 years ago
Jakob Unterwurzacher	de3a2c1895	fusefrontend: mark a few more functions as symlink-safe / unsafe	4 years ago
Jakob Unterwurzacher	8586a83825	fusefrontend: use openBackingDir in ctlsock interface ... Instead of calling syscall.Open() ourselves, rely on openBackingDir().	4 years ago
Jakob Unterwurzacher	0c1ceed1fa	fusefrontend: make GetAttr() symlink-safe ... Use openBackingDir() and Fstatat(). High performance impact, though part of it should be mitigated by adding DirIV caching to the new code paths. $ ./benchmark.bash Testing gocryptfs at /tmp/benchmark.bash.Eou: gocryptfs v1.6-37-ge3914b3-dirty; go-fuse v20170619-66-g6df8ddc; 2018-10-14 go1.11 WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.2289 s, 213 MB/s READ: 262144000 bytes (262 MB, 250 MiB) copied, 1.02616 s, 255 MB/s UNTAR: 24.490 MD5: 13.120 LS: 3.368 RM: 9.232	4 years ago
Jakob Unterwurzacher	932efbd459	fusefrontend: make openBackingDir() symlink-safe ... openBackingDir() used encryptPath(), which is not symlink-safe itself. Drop encryptPath() and implement our own directory walk. Adds three seconds to untar and two seconds to rm: $ ./benchmark.bash Testing gocryptfs at /tmp/benchmark.bash.MzG: gocryptfs v1.6-36-g8fb3c2f-dirty; go-fuse v20170619-66-g6df8ddc; 2018-10-14 go1.11 WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.25078 s, 210 MB/s READ: 262144000 bytes (262 MB, 250 MiB) copied, 1.0318 s, 254 MB/s UNTAR: 20.941 MD5: 11.568 LS: 1.638 RM: 5.337	4 years ago
Jakob Unterwurzacher	0e2e7c13cf	fusefrontend: mark symlink-safe FUSE calls ... Document which FUSE calls are already symlink-safe in the function comment.	4 years ago
Jakob Unterwurzacher	c09bf1f228	fusefrontend: make DecryptPath() symlink-safe ... DecryptPath is now symlink-safe through the use of *at() functions.	4 years ago
Jakob Unterwurzacher	ed6ed513d7	fusefrontend: make Access() symlink-safe. ... Make Access() symlink-safe through use of faccessat.	4 years ago
Jakob Unterwurzacher	545a03da24	nametransform: comments: directly link to ioutil.WriteFile fix ... So the reader does not have to read through the whole ticket. The commit message has a nice summary of the problem.	4 years ago
Sebastian Lackner	5713154468	fusefrontend: Fix debug message in doWrite() method.	4 years ago
Sebastian Lackner	9ed60678e5	fusefrontend: Fix order of arguments in debug message for Read() FUSE call.	4 years ago
Sebastian Lackner	87ced5f95d	nametransform: Delete incomplete longname files on error.	4 years ago
Sebastian Lackner	3dd5a6c069	main: Remove a duplicate word in a comment.	4 years ago
Sebastian Lackner	24594d99bf	configfile: Fix a copy&paste error in validateParams method.	4 years ago
Sebastian Lackner	07c486603c	configfile: Explicitly wipe scrypt derived key after decrypting/encrypting master key. ... Further raises the bar for recovering keys from memory.	4 years ago
Sebastian Lackner	874eaf9734	Assorted spelling fixes. ... Mostly detected with the 'codespell' utility, but also includes some manual grammar fixes.	4 years ago
Sebastian Lackner	4c2ff26457	fusefrontend: Remove unnecessary check in doRead function. ... The same condition is already checked a few lines above, and 'err' is not changed inbetween.	4 years ago
Sebastian Lackner	1ced0b192e	fusefrontend: Don't treat Fchownat error as failure in Mkdir. ... The directory was already created, so return success even if Fchownat fails. The same error handling is already used if fs.args.PlaintextNames is false.	4 years ago
Sebastian Lackner	5918884926	fusefrontend: Check the correct 'err' variable.	4 years ago
Sebastian Lackner	2a010263f6	build.bash: Escape LDFLAGS before passing them to 'go build'. ... This ensures that ./build.bash still works when the LDFLAGS environment variable contains multiple options, e.g., LDFLAGS="-lpthread -lm". The correct way of passing multiple options is discussed here: https://github.com/golang/go/issues/6234 For some unknown reason, the method only works when -extldflags is the last argument - is this a bug in Go?	4 years ago
Jakob Unterwurzacher	3cba378ad5	build.bash: support user-set LDFLAGS ... As requested at https://github.com/rfjakob/gocryptfs/pull/280	5 years ago
Jakob Unterwurzacher	bf241ce77e	build.bash: use -trimpath for reproducible builds ... Support both Go 1.7...1.9 and Go 1.10 by checking the version and using the appropropriate syntax. We trim GOPATH/src and use both -gcflags and -asmflags like Debian does in ab2bbcfc00/lib/Debian/Debhelper/Buildsystem/golang.pm (L465) .	5 years ago
Jakob Unterwurzacher	d32c149266	build.bash: respect SOURCE_DATE_EPOCH ... SOURCE_DATE_EPOCH seems to be the standard env variable for faking a build date for reproducible builds.	5 years ago
Jakob Unterwurzacher	9daa205c10	README: replace openssl-gcm.md with link to wiki ... The CPU-Benchmarks wiki page has a lot more info than openssl-gcm.md had.	5 years ago
Jakob Unterwurzacher	a55e53c196	tests: fix TestPassfileNewline ... Due to a copy-paste error, we ran the wrong test in the subprocess. Thanks @slackner for noticing at 295d432175 (r31690478) !	5 years ago
Jakob Unterwurzacher	295d432175	passfile: directly read file instead of invoking cat ... Allows better error handling, gets rid of the call to an external program, and fixes https://github.com/rfjakob/gocryptfs/issues/278 .	5 years ago
Jakob Unterwurzacher	b29ee62749	Add v1.6.1 to changelog	5 years ago
Jakob Unterwurzacher	e665df7179	syscallcompat: downgrade DT_UNKNOWN message level on XFS ... Old XFS filesystems always return DT_UNKNOWN. Downgrade the message to "info" level if we are on XFS. Using the "warning" level means that users on old XFS filesystems cannot run the test suite as it intentionally aborts on any warnings. Fixes https://github.com/rfjakob/gocryptfs/issues/267	5 years ago
Jakob Unterwurzacher	d882ed45da	main: drop hardcoded /usr/bin/logger path ... The hardcoded full paths were introduced to handle the case of an empty PATH environment variable. However, since commit 10212d791a we set PATH to a default value if empty. The hardcoded paths are no longer neccessary, and cause problems on some distros: User voobscout on https://github.com/rfjakob/gocryptfs/issues/225#issuecomment-438682034 : just to chime in - please don't hardcode paths, for example I'm on NixOS and logger lives in /run/current-system/sw/bin/logger Drop the hardcoded paths.	5 years ago
Jakob Unterwurzacher	1ed08c7384	tlog: disable color codes when switching to syslog ... When gocryptfs was started on a terminal and later daemonized, the color codes stayed active in the syslog output. The codes are not visible in "journalctl -f", which is why I have not noticed it yet, but they do show up in normal syslog as the usual "#033[33m" crap.	5 years ago
Jakob Unterwurzacher	4cdf6b9af9	fusefronted: log more details on WriteAt failures ... Also log inode number, fd number, offset and length. Maybe help debugging https://github.com/rfjakob/gocryptfs/issues/269 .	5 years ago