@pilou what's the best way forward for a merge? Shall I merge into the master here, or is it auto-pulled from the master branch on duckcorp and needs a manual merge?
There isn't any…
Not a request to change: i would have used return *irc_code == '4';
because it seems closer to the style used in this file.
Other functions use int
instead of unsigned int
. Should unsigned int
be used everywhere? Or c99/stdbool.h be used?
When bip_notify
is used, required parameters are surrounded by<
/>
and optional parameter are surrounded by [
/]
.
link_name
isn't global/unique: in order to prevent any future issue when this method will be used/called elsewhere : should not the bipuser
parameter be required (meaning should not find_link
return NULL
when bu
is NULL
)?
Use square brackets in the message (same as in the other messages where required/optional parameters are surrounded by brackets):