Claire 02851848e9
Revamp post filtering system (#18058)
* Add model for custom filter keywords

* Use CustomFilterKeyword internally

Does not change the API

* Fix /filters/edit and /filters/new

* Add migration tests

* Remove whole_word column from custom_filters (covered by custom_filter_keywords)

* Redesign /filters

Instead of a list, present a card that displays more information and handles
multiple keywords per filter.

* Redesign /filters/new and /filters/edit to add and remove keywords

This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.

* Add /api/v2/filters to edit filter with multiple keywords

Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
  `keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`

API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
  `keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
  `keywords_attributes` can also be passed to edit, delete or add keywords in
   one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
   filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword

* Change from `irreversible` boolean to `action` enum

* Remove irrelevent `irreversible_must_be_within_context` check

* Fix /filters/new and /filters/edit with update for filter_action

* Fix Rubocop/Codeclimate complaining about task names

* Refactor FeedManager#phrase_filtered?

This moves regexp building and filter caching to the `CustomFilter` class.

This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.

* Perform server-side filtering and output result in REST API

* Fix numerous filters_changed events being sent when editing multiple keywords at once

* Add some tests

* Use the new API in the WebUI

- use client-side logic for filters we have fetched rules for.
  This is so that filter changes can be retroactively applied without
  reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
  (e.g. network error, or initial timeline loading)

* Minor optimizations and refactoring

* Perform server-side filtering on the streaming server

* Change the wording of filter action labels

* Fix issues pointed out by linter

* Change design of “Show anyway” link in accordence to review comments

* Drop “irreversible” filtering behavior

* Move /api/v2/filter_keywords to /api/v1/filters/keywords

* Rename `filter_results` attribute to `filtered`

* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer

* Fix systemChannelId value in streaming server

* Simplify code by removing client-side filtering code

The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
2022-06-28 09:42:13 +02:00
..
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-04 13:44:49 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2021-04-22 00:04:58 +02:00
2021-04-22 03:27:43 +02:00
2022-03-11 14:35:51 +09:00
2021-04-22 00:04:58 +02:00
2022-02-11 04:50:27 +01:00
2022-05-15 18:04:59 +09:00
2022-03-17 09:33:25 +09:00
2020-11-09 00:56:52 +01:00
2021-05-16 23:54:25 +02:00
2022-03-20 00:23:01 +09:00
2020-11-09 00:56:52 +01:00
2020-11-09 00:56:52 +01:00
2022-03-11 14:35:51 +09:00
2020-11-09 00:56:52 +01:00
2021-05-08 17:12:56 +02:00
2021-05-20 00:19:52 +02:00
2021-04-22 00:04:58 +02:00
2022-05-30 15:49:43 +09:00
2021-10-17 10:28:51 +09:00
2022-02-11 04:50:27 +01:00
2022-06-04 13:44:49 +09:00
2022-04-24 06:33:26 +09:00
2021-04-22 00:04:58 +02:00
2022-05-30 15:49:43 +09:00
2022-05-06 21:53:22 +09:00
2021-04-22 00:04:58 +02:00
2020-11-09 00:56:52 +01:00
2021-10-17 10:28:51 +09:00
2022-02-11 04:50:27 +01:00
2021-05-08 17:12:56 +02:00
2022-05-24 23:33:18 +09:00
2020-11-09 00:56:52 +01:00
2022-02-11 04:50:27 +01:00
2022-05-02 23:19:23 +09:00
2022-02-11 04:50:27 +01:00
2021-10-17 10:28:51 +09:00
2022-03-29 10:51:09 +09:00
2021-04-22 00:04:58 +02:00
2021-10-17 10:28:51 +09:00
2021-05-08 17:12:56 +02:00
2020-11-26 22:42:12 +09:00
2020-11-09 00:56:52 +01:00
2020-11-09 00:56:52 +01:00
2021-04-22 00:04:58 +02:00
2020-11-09 00:56:52 +01:00
2021-10-17 10:28:51 +09:00
2021-10-17 10:28:51 +09:00
2022-02-11 04:50:27 +01:00
2022-05-19 19:58:16 +09:00
2020-11-09 00:56:52 +01:00
2021-04-22 00:04:58 +02:00
2021-10-17 10:28:51 +09:00
2022-02-11 04:50:27 +01:00
2021-05-08 17:12:56 +02:00
2021-04-22 00:04:58 +02:00
2021-06-02 21:09:18 +02:00
2022-05-06 21:53:22 +09:00
2022-04-22 03:21:08 +09:00
2021-05-08 17:12:56 +02:00
2020-07-10 20:57:21 +02:00
2020-11-09 00:56:52 +01:00
2022-04-28 14:34:28 +09:00
2020-11-10 16:53:54 +09:00
2022-05-02 23:19:23 +09:00
2020-12-16 03:24:55 +01:00
2022-05-15 18:04:59 +09:00
2022-06-16 13:31:19 +09:00
2022-05-15 18:04:59 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-04-28 14:34:28 +09:00
2022-03-11 14:35:51 +09:00
2022-04-08 19:52:22 +09:00
2022-03-11 14:35:51 +09:00
2022-03-20 00:23:01 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-05-24 23:33:18 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-03-17 09:33:25 +09:00
2022-05-02 23:19:23 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-06-04 13:44:49 +09:00
2022-04-24 06:33:26 +09:00
2022-03-29 10:51:09 +09:00
2022-03-11 14:35:51 +09:00
2022-05-06 21:53:22 +09:00
2020-11-09 00:56:52 +01:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-05-02 23:19:23 +09:00
2022-03-24 19:23:46 +09:00
2022-05-24 23:33:18 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-05-02 23:19:23 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-04-28 14:34:28 +09:00
2022-03-29 10:51:09 +09:00
2021-04-22 00:04:58 +02:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-03-24 19:23:46 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-04-08 19:52:22 +09:00
2021-04-22 00:04:58 +02:00
2022-04-14 02:52:53 +09:00
2022-03-11 14:35:51 +09:00
2022-06-04 13:44:49 +09:00
2020-11-09 00:56:52 +01:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-03-20 00:23:01 +09:00
2022-05-06 21:53:22 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2022-05-15 18:04:59 +09:00
2022-03-11 14:35:51 +09:00
2022-03-11 14:35:51 +09:00
2020-07-10 20:57:21 +02:00
2022-05-06 21:53:22 +09:00
2022-04-28 14:34:28 +09:00
2022-06-16 13:31:19 +09:00
2022-05-02 23:19:23 +09:00
2022-06-28 09:42:13 +02:00
2022-06-26 12:08:08 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-04 13:44:49 +09:00
2022-04-28 14:34:28 +09:00
2022-06-16 13:31:19 +09:00
2022-06-26 12:08:08 +09:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-26 12:08:08 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-26 12:08:08 +09:00
2022-06-16 13:31:19 +09:00
2021-10-17 10:28:51 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2022-06-26 12:08:08 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2021-04-22 00:04:58 +02:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2022-03-11 14:35:51 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2021-04-22 00:04:58 +02:00
2022-02-19 13:20:00 +09:00
2022-06-26 12:08:08 +09:00
2022-06-26 12:08:08 +09:00
2022-03-15 03:01:59 +09:00
2020-11-09 00:56:52 +01:00
2022-06-26 12:08:08 +09:00
2020-11-09 00:56:52 +01:00
2022-06-16 13:31:19 +09:00
2022-03-11 14:35:51 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00
2022-06-16 13:31:19 +09:00